Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert a3e434083a05b64756736aeb196c48e42660c122 #12134

Merged

Conversation

sethkfman
Copy link
Contributor

Description

Revert a3e4340

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested review from a team as code owners October 31, 2024 21:08
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 31, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad1d325
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3dbc057e-d0f6-4126-a1d7-21409c404bec

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/base-controller@7.0.1 None 0 344 kB metamaskbot

🚮 Removed packages: npm/@metamask/base-controller@7.0.2, npm/@metamask/controller-utils@11.4.2

View full report↗︎

Copy link

@sethkfman sethkfman merged commit 04d0b20 into release/7.34.0 Oct 31, 2024
38 of 39 checks passed
@sethkfman sethkfman deleted the fix/revert-a3e434083a05b64756736aeb196c48e42660c122 branch October 31, 2024 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@sethkfman sethkfman restored the fix/revert-a3e434083a05b64756736aeb196c48e42660c122 branch November 1, 2024 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant