Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rpc-errors #12147

Merged
merged 3 commits into from
Nov 1, 2024
Merged

chore: bump rpc-errors #12147

merged 3 commits into from
Nov 1, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 1, 2024

Description

Upgrade @metamask/rpc-errors from 6.3.1 to 6.4.0.

Update Babel ignore filter to not match all files ending with ses.cjs such as classes.cjs from @metamask/rpc-errors.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Nov 1, 2024
Copy link

socket-security bot commented Nov 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/rpc-errors@6.4.0 None 0 165 kB metamaskbot

🚮 Removed packages: npm/@metamask/rpc-errors@6.3.1

View full report↗︎

@matthewwalsh0 matthewwalsh0 changed the title bump: upgrade rpc-errors chore: bump rpc-errors Nov 1, 2024
@matthewwalsh0 matthewwalsh0 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e5a890c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3811fcca-fd1d-4a8b-9eca-57c3d4818d82

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e123143
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1d13e3f6-141d-48ba-8f99-00864454e5f5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 1, 2024 12:12
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners November 1, 2024 12:12
babel.config.js Outdated Show resolved Hide resolved
OGPoyraz
OGPoyraz previously approved these changes Nov 1, 2024
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 04beaf0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/51136588-46dd-4a97-8a92-dfd97359968b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Nov 1, 2024

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit db39208 Nov 1, 2024
43 checks passed
@matthewwalsh0 matthewwalsh0 deleted the chore/bump-rpc-errors branch November 1, 2024 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024
@sethkfman sethkfman added release-7.34.0 and removed release-7.36.0 Issue or pull request that will be included in release 7.36.0 labels Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants