chore(test): add new unit tests after removing exclusions from Sonar config #13031
+1,822
−2,033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s true, to check CI
…code) from NetworkVerificationInfo component
…code that ran when feature flag was off (which was now dead code)
…ture flag, remove code that ran when feature flag was off (which was now dead code)
…ks on feature flag, remove code that ran when feature flag was off (which was now dead code)
…e. Update the test to mock nav, and snapshot expected to be updated too.
…tests. In more detail, after removal of feature flag and corresponding dead code of ff-off, test now runs on ff-on and required update to show content of accordion before asserting, and update snapshot to match new expected rendering.
…t component default style was changed in main
…r multichain and the deadcode behind it. In the case of this component, it didn't directly have multichain code in it but was rendering a component which did (NetworkVerificationInfo)
… feature flag for multichain and the deadcode behind it. It needs this since it uses components than end up using NetworkVerificationInfo which had some code toggled on and off based on the multichain feature flag which is being removed in this PR.
…eature flag was ON. This check on the feature flag was used in some components to render stuff that should render only when the flag was ON.
…ubleshooting during code cleanup
… since all multichain-permission code is ff-on now
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13031 +/- ##
==========================================
+ Coverage 59.83% 59.94% +0.10%
==========================================
Files 1873 1884 +11
Lines 42121 42202 +81
Branches 5473 5476 +3
==========================================
+ Hits 25204 25298 +94
+ Misses 15235 15213 -22
- Partials 1682 1691 +9 ☔ View full report in Codecov by Sentry. |
EtherWizard33
changed the title
EtherWizard33
changed the base branch from
main
to
refactor-3663-chain-permissions-feature-flag-etc
EtherWizard33
added
Run Smoke E2E
|
EtherWizard33
changed the title
EtherWizard33
changed the title
EtherWizard33
added
Run Smoke E2E
|
|
EtherWizard33
added
Run Smoke E2E
EtherWizard33
changed the base branch from
refactor-3663-chain-permissions-feature-flag-etc
to
main
EtherWizard33
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the sonar coverage after removing exclusions for the sonar config file
Related issues
Contributes to: https://github.com/MetaMask/MetaMask-planning/issues/3663
Manual testing steps
run the unit tests using yarn test:unit
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist