chore: move metrics identify to state listener

[NicolasMassart]

Description

• moves identify call to active app state listener
• updates unit tests
• also fixes trackEvent mock wrongly being used as async in app/core/AppStateEventListener.test.ts

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/2119

Manual testing steps

Feature: identify users
  Scenario: identify on app state change to active
    Given an already onboarded app
    And user opted in for metrics
    When you open the app in local dev mode
    Then you have the `IDENTIFY event saved` log

Screenshots/Recordings

Before

IDENTIFY event sent but only on app open and not when foregrounding (active)

After

 INFO  IDENTIFY event saved {"traits": {"Batch account balance requests": "ON", "Enable OpenSea API": "ON", "NFT Autodetection": "ON", "Theme": "light", "applicationVersion": "7.37.1", "currentBuildNumber": "1520", "deviceBrand": "Apple", "operatingSystemVersion": "18.2", "platform": "ios", "security_providers": "blockaid", "token_detection_enable": "ON"}, "type": "identify", "userId": "150739a9-38b7-4098-b1f0-7afbba0b2e5d"}
 INFO  TRACK event saved {"event": "App Opened", "properties": {}, "type": "track"}
 INFO  Sent 2 events

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f9ef78
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d28d55ca-776b-4c43-9609-2c350dfbabf0

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Cal-L]

Left a comment

[Cal-L]

LGTM

[chrisleewilcox]

LGTM