Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add getPreferences hook #14062

Merged
merged 8 commits into from
Mar 25, 2025
Merged

feat: Add getPreferences hook #14062

merged 8 commits into from
Mar 25, 2025

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Mar 17, 2025

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? Add snap_getPreferences functionality.

Related issues

Fixes: MetaMask/snaps#3199

Manual testing steps

  1. Install the preferences Snap
  2. Click "submit"
  3. See that all of the expected preferences are available

Screenshots/Recordings

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 17, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Mar 17, 2025
@hmalik88
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@FrederikBolding FrederikBolding added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Mar 24, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
16.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@FrederikBolding FrederikBolding changed the title Add get preferences feat: Add getPreferences hook Mar 25, 2025
@FrederikBolding FrederikBolding marked this pull request as ready for review March 25, 2025 12:09
@FrederikBolding FrederikBolding requested a review from a team as a code owner March 25, 2025 12:09
@FrederikBolding FrederikBolding added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 25, 2025
Copy link
Contributor

github-actions bot commented Mar 25, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5cd73b5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8c36bbc-23ba-42c3-b700-731097520e32

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 1d89311 Mar 25, 2025
44 of 49 checks passed
@FrederikBolding FrederikBolding deleted the hm/add-get-preferences branch March 25, 2025 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.44.0 Issue or pull request that will be included in release 7.44.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement snap_getPreferences on mobile
4 participants