chore(runway): cherry-pick fix: cp-7.47.0 Add safe checksum method in SendTo page
#15309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `SendTo` page (#15308) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix an issue when user puts an unexpected value into `to` field in send flow. It appears from that [the issue](https://metamask.sentry.io/issues/6582066742/?project=2299799) is thrown by `toChecksumAddress` because it doesn't expect any incomplete address. However in send flow UX we let user to type in address themselves. To test this you can go `SendTo` page and put `K` for example - and see the crash. (Screenshot below is fixed version) **Labels** Adding `skip-sonar-cloud` as the raised issue was intentional.  ## **Related issues** Fixes: #15094 ## **Manual testing steps** 1. Go to send flow 2. Input an unexpected address 3. Confirm warning shown - you shouldn't be proceed next step ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
team-runway-bot-deprecated
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/7.47.0 #15309 +/- ##
=================================================
Coverage ? 68.64%
=================================================
Files ? 2376
Lines ? 51324
Branches ? 7640
=================================================
Hits ? 35229
Misses ? 13857
Partials ? 2238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
OGPoyraz
approved these changes
May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendTopage (fix: cp-7.47.0 Add safe checksum method inSendTopage #15308)Description
This PR aims to fix an issue when user puts an unexpected value into
tofield in send flow.It appears from that the
issue is
thrown by
toChecksumAddressbecause it doesn't expect any incompleteaddress. However in send flow UX we let user to type in address
themselves.
To test this you can go
SendTopage and putKfor example - and seethe crash. (Screenshot below is fixed version)
Labels
Adding
skip-sonar-cloudas the raised issue was intentional.Related issues
Fixes: #15094
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. b22bfcc