Skip to content

Conversation

@ffmcgee725
Copy link
Member

Description

Having a chain permitted on a dapp, and then removing said network from wallet throws an error when going back to dapp and trying to switch to the currently selected network. Original ticket for the issue is here.

This PR makes sure we properly filter out the deleted network when updating the permission for the currently selected network/s.

Related issues

Fixes:
#15201

Manual testing steps

  1. Go to any dapp via in app browser
  2. Connect and permit a chain (ex.: Polygon)
  3. Go back to wallet
  4. Change selected chain (ex.: to Ethereum mainnet)
  5. Remove the previously permitted chain from the available networks (ex.: remove Polygon)
  6. Go back to dapp and confirm adding the newly selected chain
  7. No exception should show up ✅

Screenshots/Recordings

Before

Screen.Recording.2025-05-15.at.09.36.40.mov

After

Screen.Recording.2025-05-15.at.11.58.59.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label May 15, 2025
@ffmcgee725 ffmcgee725 added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels May 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 73cf75b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0283609-d0d5-4962-b6b8-cd2b2feac3a3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

@ffmcgee725 ffmcgee725 enabled auto-merge May 15, 2025 10:42
@ffmcgee725
Copy link
Member Author

This one pipeline run_trade_swimlane_android_smoke failed, but it's been known for flakyness for some time now so I will push this forward

@ffmcgee725 ffmcgee725 added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit a21b310 May 15, 2025
58 of 63 checks passed
@ffmcgee725 ffmcgee725 deleted the fix/permission-error-caip25-authorized-scopes branch May 15, 2025 11:14
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants