chore(runway): cherry-pick fix: cp-7.47.0 add MetaMask fee disclaimer text to bridge view #15380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text to bridge view (#15377) ## **Description** This PR adds a fee disclaimer text to the Bridge View to inform users about the 0.875% MetaMask fee. This change improves transparency by clearly communicating the fee structure to users before they proceed with a bridge transaction. ## **Related issues** Fixes: [MMS-2343](https://consensyssoftware.atlassian.net/browse/MMS-2343) ## **Manual testing steps** 1. Open the Bridge View 2. Verify that the fee disclaimer text "Includes 0.875% MM fee" appears below the quote details 3. Confirm the text is properly aligned and styled 4. Test with different screen sizes to ensure responsive layout ## **Screenshots/Recordings** ### **Before** [Please add screenshot of Bridge View without fee disclaimer] ### **After** https://github.com/user-attachments/assets/452f9b31-f797-4033-9f47-6b766627bc8d ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [MMS-2343]: https://consensyssoftware.atlassian.net/browse/MMS-2343?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-runway-bot-deprecated
Contributor
|
NicolasMassart
approved these changes
May 16, 2025
|
Contributor
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a fee disclaimer text to the Bridge View to inform users
about the 0.875% MetaMask fee. This change improves transparency by
clearly communicating the fee structure to users before they proceed
with a bridge transaction.
Related issues
Fixes:
MMS-2343
Manual testing steps
below the quote details
Screenshots/Recordings
Before
[Please add screenshot of Bridge View without fee disclaimer]
After
Screen.Recording.2025-05-15.at.5.50.33.PM.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
MMS-2343:
https://consensyssoftware.atlassian.net/browse/MMS-2343?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ebce0f0