Fix env vars #1645
Merged
Fix env vars #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
added
the
QA'd - Issues Found
ibrahimtaveras00
approved these changes
Jun 25, 2020
ibrahimtaveras00
added
QA Passed
rickycodes
suggested changes
Jun 25, 2020
app/core/Analytics.js
Outdated
Comment on lines
219
to
227
| if (!__DEV__) { | ||
| RCTAnalytics.trackEvent({ | ||
| ...event, | ||
| ...params, | ||
| value, | ||
| info | ||
| }); | ||
| } else { | ||
| Logger.log(`Analytics 'trackEventWithValueAndParameters' - `, event, value, info, params); |
There was a problem hiding this comment.
maybe this could be a method? looks like we're dong the same thing 6x
andrepimenta
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
The only recommendation I have is to put code like this:
if (!__DEV__) {
RCTAnalytics.trackEvent(event);
} else {
Logger.log(`Analytics 'trackEvent' - `, event);
}
On a function outside on a service or helper that would look like:
const trackEvent = event => {
if (!__DEV__) {
RCTAnalytics.trackEvent(event);
} else {
Logger.log(`Analytics 'trackEvent' - `, event);
}
}
And then you could call trackEvent(event) everywhere so we don't repeat code. This is especially important if we need to use that function more times in the future.
And the same for !__DEV__ && RCTAnalytics.optIn(this.enabled);
Otherwise looks good to me!!
|
@rickycodes @andrepimenta it totally makes sense, it was that way before so I didn't question it 🤦 |
rickycodes
approved these changes
Jun 26, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* enable-apple-pay * analytics only on not dev * startwatcher * dev * env. * DRY analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Env vars haven't been working on debug mode for a while now, this PR fixes that so we can use all the features on debug mode.
Checklist
Issue
Resolves #???