Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blank browser tab #1676

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Fix blank browser tab #1676

merged 2 commits into from
Jul 10, 2020

Conversation

andrepimenta
Copy link
Member

Description

This fixes homepage not loading on a previously opened tab after a user completely closes a opens the app.

Issue

Resolves #1635

@andrepimenta andrepimenta requested a review from a team as a code owner July 7, 2020 14:26
@andrepimenta andrepimenta added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 7, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good on both OS's, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 10, 2020
@andrepimenta andrepimenta merged commit a34da39 into develop Jul 10, 2020
@andrepimenta andrepimenta deleted the improvement/fix-blank-browser-tab branch July 10, 2020 10:35
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Initiate url as well (#1676)
729a1a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

home.metamask.io not loading on MMM
3 participants
@andrepimenta @estebanmino @ibrahimtaveras00