Skip to content

Conversation

@hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Jun 30, 2025

Description

This PR fix e2e and performance test for #15883

Related issues

Fixes:

  • Update testId for Onboarding flow button
  • Add OnboardingSheet to flows
  • Update test utilities use in other module

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

ieow and others added 20 commits June 26, 2025 11:26
remove unwanted lint changes
- Added OnboardingSheet component for user onboarding options.
- Integrated AccountStatus component to handle existing account scenarios.
- Updated navigation routes to include new onboarding flows.
- Enhanced ChoosePassword component to support OAuth login success handling.
- Updated localization files to include new strings for onboarding and account status.
- Added tests for new components and updated existing tests for integration.

This commit enhances the user experience during onboarding and account management by providing clear options and feedback for existing users.
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hieu-w hieu-w changed the title Feat/e2e fix for seedless oauth flow test/e2e fix for seedless oauth flow Jun 30, 2025
@hieu-w hieu-w marked this pull request as ready for review June 30, 2025 03:52
@hieu-w hieu-w requested a review from a team as a code owner June 30, 2025 03:52
ieow
ieow previously approved these changes Jul 24, 2025
Copy link
Contributor

@ieow ieow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hieu-w hieu-w added this pull request to the merge queue Jul 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2025
@chaitanyapotti chaitanyapotti changed the title test: e2e fix for seedless oauth flow test: e2e fix for seedless oauth flow cp-7.52.0 Jul 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 63a2c10
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e28ad809-09a8-4ad2-8523-ef3aadcac1b4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

@ieow ieow added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit da222bd Jul 24, 2025
56 of 58 checks passed
@ieow ieow deleted the feat/e2e-fix-for-seedless-oauth-flow branch July 24, 2025 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 24, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants