Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/approve suggested amount #1685

Merged
merged 1 commit into from
Jul 9, 2020
Merged

bugfix/approve suggested amount #1685

merged 1 commit into from
Jul 9, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jul 8, 2020 •
edited
Loading

Description

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner July 8, 2020 21:59
@estebanmino estebanmino changed the base branch from develop to bugfix/release-bugs July 9, 2020 16:53
@estebanmino estebanmino added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 9, 2020
@estebanmino estebanmino merged commit 0403bb4 into bugfix/release-bugs Jul 9, 2020
@estebanmino estebanmino deleted the bigfix/approve-suggested-amount branch July 9, 2020 20:32
@estebanmino estebanmino mentioned this pull request Jul 9, 2020
Merged
3 tasks
estebanmino added a commit that referenced this pull request Jul 10, 2020
@estebanmino
Bugfix/release bugs (#1690)
c3bebf8 
* Bugfix/analytics disabled on dev mode (#1682)

* update locales

* enabled for dev but it doesn't send data

* snapshots

* bugfix/approve suggested amount (#1685)

* bugfix/transaction scrollbar position (#1686)

* update copy
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Bugfix/release bugs (#1690)
e13b04f 
* Bugfix/analytics disabled on dev mode (#1682)

* update locales

* enabled for dev but it doesn't send data

* snapshots

* bugfix/approve suggested amount (#1685)

* bugfix/transaction scrollbar position (#1686)

* update copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Approve view shows incorrect Amount value
2 participants
@estebanmino @rickycodes