Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase ANDROID_OFFSET #1697

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Increase ANDROID_OFFSET #1697

merged 1 commit into from
Jul 17, 2020

Conversation

rickycodes
Copy link
Contributor

Before:

image

After:

image

@rickycodes rickycodes requested a review from estebanmino July 15, 2020 15:14
@rickycodes rickycodes requested a review from a team as a code owner July 15, 2020 15:14
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 15, 2020
@rickycodes rickycodes force-pushed the fix-add-funds-button branch 2 times, most recently from de12249 to 7ea1167 Compare July 15, 2020 16:43
estebanmino
estebanmino approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estebanmino estebanmino removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 15, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good now, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 16, 2020
@rickycodes rickycodes force-pushed the fix-add-funds-button branch from 7ea1167 to 58e464c Compare July 17, 2020 00:37
@rickycodes rickycodes merged commit 9986e89 into develop Jul 17, 2020
@rickycodes rickycodes deleted the fix-add-funds-button branch July 17, 2020 00:55
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Increase ANDROID_OFFSET (#1697)
e956348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickycodes @estebanmino @ibrahimtaveras00