Skip to content

Conversation

@georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Jul 8, 2025

Description

  • Fixes android DOB
  • Adds next-input focusing when using autofill
screen-20250708-135347.mp4
ScreenRecording_07-08-2025.13-51-58_1.MP4
ScreenRecording_07-08-2025.21-32-41_1.MP4
screen-20250709-064245.mp4

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Jul 8, 2025
@georgeweiler georgeweiler added Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. labels Jul 9, 2025
@georgeweiler georgeweiler marked this pull request as ready for review July 9, 2025 12:44
@georgeweiler georgeweiler requested a review from a team as a code owner July 9, 2025 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6115bf6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/819d60d1-134e-4fa7-a5c8-92bcf0f8352e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SSN Field Submission Issue

Pressing "Done" on the keyboard for the SSN field (the last form field) no longer submits the form and proceeds to the next screen. This is because the handleOnPressContinue() call was removed from its onSubmitEditing handler. Users must now manually tap the "Continue" button, which is a regression in the expected user experience.

app/components/UI/Ramp/Deposit/Views/BasicInfo/BasicInfo.tsx#L254-L257

maxLength={11}
onSubmitEditing={() => {
Keyboard.dismiss();
}}

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fb19722
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab597f74-89b6-46c3-aba1-888bd4bd938f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@georgeweiler georgeweiler added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit ff749cc Jul 9, 2025
55 of 57 checks passed
@georgeweiler georgeweiler deleted the deposit-android-dob-fix branch July 9, 2025 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-ramp issues related to Ramp features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants