Skip to content

Conversation

@brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jul 9, 2025

Description

This PR

  • Adds the DisplayLG variant to the Text component
  • Updated homepage balance to use DisplayLG variant
  • Updated show/hide icon to match design

Figma Link: https://www.figma.com/design/9e6RSJCvezaLqDQ3mtE5wB/MaWaSB?node-id=3127-19374&t=UoqfNNxzdgayOiQj-0

Changelog

CHANGELOG entry: Updated Portfolio Balance text style

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5238

Manual testing steps

  1. Go to Wallet
  2. Check Balance text

Screenshots/Recordings

Before

Simulator Screenshot - iPhone 15 Pro Max - 2025-07-08 at 13 34 45

After

iOS
Simulator Screenshot - iPhone 15 Pro Max - 2025-07-08 at 13 34 54

Android
Screenshot_1752091758

Storybook
Simulator Screenshot - iPhone 15 Pro Max - 2025-07-08 at 14 58 24

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen self-assigned this Jul 9, 2025
@brianacnguyen brianacnguyen requested review from a team as code owners July 9, 2025 17:28
@brianacnguyen brianacnguyen added No QA Needed Apply this label when your PR does not need any QA effort. team-design-system All issues relating to design system in Mobile No E2E Smoke Needed labels Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

@amandaye0h
Copy link
Contributor

amandaye0h commented Jul 9, 2025

Can you clarify if the after screenshot is from an iOS or Android build? Would it be possible to get an Android screenshot, just to make sure the fallback font isn't used?

@brianacnguyen
Copy link
Contributor Author

Can you clarify if the after screenshot is from an iOS or Android build? Would it be possible to get an Android screenshot, just to make sure the fallback font isn't used?

It's iOS. I'll update the description with the Android screenshot in a little bit

@brianacnguyen brianacnguyen added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 491cd92 Jul 9, 2025
45 checks passed
@brianacnguyen brianacnguyen deleted the homepage/balance branch July 9, 2025 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
@amandaye0h
Copy link
Contributor

@brianacnguyen Looks like the fallback font is being displayed in the balance component for Android — can you make sure Geist is applied on Android?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants