-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: Add DisplayLG variant to Text component and updated homepage balance to use DisplayLG variant #17038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to homepage/balance
…to homepage/balance
…to homepage/balance
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
Can you clarify if the after screenshot is from an iOS or Android build? Would it be possible to get an Android screenshot, just to make sure the fallback font isn't used? |
It's iOS. I'll update the description with the Android screenshot in a little bit |
|
@brianacnguyen Looks like the fallback font is being displayed in the balance component for Android — can you make sure Geist is applied on Android? |



Description
This PR
DisplayLGvariant to theTextcomponentDisplayLGvariantFigma Link: https://www.figma.com/design/9e6RSJCvezaLqDQ3mtE5wB/MaWaSB?node-id=3127-19374&t=UoqfNNxzdgayOiQj-0
Changelog
CHANGELOG entry: Updated Portfolio Balance text style
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5238
Manual testing steps
Screenshots/Recordings
Before
After
iOS

Android

Storybook

Pre-merge author checklist
Pre-merge reviewer checklist