Skip to content

Conversation

@wachunei
Copy link
Member

@wachunei wachunei commented Jul 9, 2025

Description

This PR refactors OTP input to method calling that throws, also submits code immediately

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei changed the title refactor(deposit): otp usese throws method refactor(deposit): otp uses throws method Jul 9, 2025
@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Jul 9, 2025
@wachunei wachunei changed the title refactor(deposit): otp uses throws method refactor(deposit): verify otp uses throws method Jul 9, 2025
@wachunei wachunei marked this pull request as ready for review July 9, 2025 22:33
@wachunei wachunei requested a review from a team as a code owner July 9, 2025 22:33
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: bcf9122
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f11c6b1-126b-446f-b2b1-9e28e49428e3

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8aef36f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac0c4301-e0ea-4c7c-8f8e-48e525a7cd2d

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7eedfc6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/62df9e75-38c0-4b79-8dcc-2e2d96a8224c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2798a0e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/971caf21-f730-40ee-935c-e18467c08f0d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

@wachunei wachunei added the QA Passed QA testing has been completed and passed label Jul 10, 2025
@wachunei wachunei enabled auto-merge July 10, 2025 01:29
@wachunei wachunei added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 46137a4 Jul 10, 2025
87 of 170 checks passed
@wachunei wachunei deleted the refactor/deposit-otp-method branch July 10, 2025 01:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-ramp issues related to Ramp features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants