Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for pods first, don't double up on yarn install(s) #1730

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Jul 29, 2020

On linux the yarn clean command does not exit correctly:

yarn clean
...
2. Create xcconfig files...
3. Init git submodules
This may take a while...
/bin/sh: 1: pod: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I don't have pods on my computer, so i can't install them. this has bitten me a couple times when I've tried to chain off of (&&) yarn clean

eg: yarn clean && echo "now I am happy"

checking for the pod command first means now I am happy:

$ yarn clean && echo "now I am happy"
yarn run v1.22.4
...
2. Create xcconfig files...
3. Init git submodules
This may take a while...
$ command -v pod && (cd ios/ && pod install && cd ..) || echo "pod command not found"
pod command not
Done in 22.50s.
now I am happy

we were also doubling up on yarn installs in the clean flow for no reason, clean:node handles a new yarn install so it's pointless to do it again after that.

@rickycodes rickycodes requested a review from a team as a code owner July 29, 2020 02:43
@rickycodes rickycodes force-pushed the feature/fix-package-json branch from c7aade9 to 1c3265f Compare July 29, 2020 14:08
@rickycodes rickycodes added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 29, 2020
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice!

@rickycodes rickycodes force-pushed the feature/fix-package-json branch from 1c3265f to d9261a7 Compare July 30, 2020 14:16
@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 30, 2020
@rickycodes rickycodes force-pushed the feature/fix-package-json branch 4 times, most recently from e92ef42 to fac127a Compare July 31, 2020 13:36
@rickycodes rickycodes force-pushed the feature/fix-package-json branch from fac127a to b0ce0c1 Compare July 31, 2020 15:14
@rickycodes rickycodes merged commit c36a700 into develop Jul 31, 2020
@rickycodes rickycodes deleted the feature/fix-package-json branch July 31, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants