Fix scroll and button text and secure now goes to next step #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
suggested changes
Jul 30, 2020
| @@ -141,7 +141,7 @@ | |||
| "subtitle": "This password will unlock your MetaMask wallet only on this device.", | |||
| "password": "New Password", | |||
| "confirm_password": "Confirm Password", | |||
| "create_button": "NEXT", | |||
| "create_button": "Create password", | |||
There was a problem hiding this comment.
why not just reuse the title?
metamask-mobile/locales/en.json
Line 140 in 09b5bd3
There was a problem hiding this comment.
I think we later could want to change the title without changing the button text and vice-versa?
rickycodes
approved these changes
Jul 30, 2020
andrepimenta
added
needs-qa
…taMask/metamask-mobile into bugfix/scroll-choose-password
andrepimenta
changed the title
ibrahimtaveras00
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Fix scroll and button text * Update tests * secure now goes to next step Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix scroll on choose password and button text and secure now goes to next step
Checklist
Issue
Resolves #???