Improvement/migrate aes crypto lib #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent/migrate-aes-crypto-lib # Conflicts: # package.json # yarn.lock
estebanmino
reviewed
Aug 6, 2020
app/core/Vault.js
Outdated
| * | ||
| * @param password - Password to recreate and set the vault with | ||
| */ | ||
| export const recreateVault = async (password = '', selectedAddress) => { |
There was a problem hiding this comment.
is this taking imported accounts or it's going to be deleted?
ibrahimtaveras00
added
next release
QA in Progress
ibrahimtaveras00
approved these changes
Aug 7, 2020
ibrahimtaveras00
added
QA Passed
ibrahimtaveras00
added
needs-qa
ibrahimtaveras00
suggested changes
Aug 10, 2020
ibrahimtaveras00
added
QA'd - Issues Found
andrepimenta
added
needs-qa
estebanmino
reviewed
Aug 11, 2020
| const { KeyringController, PreferencesController } = Engine.context; | ||
| const seedPhrase = await getSeedPhrase(password); | ||
|
|
||
| let importedAccounts = []; |
There was a problem hiding this comment.
seems like is the same code right? https://github.com/MetaMask/metamask-mobile/pull/1756/files#diff-05500d00f4a6959745b57a220987a4b6R359
would be nice to have Logger here to know what's going on and remove duplicated code, but we can do the last after releasing
|
Imported accounts are not lost on login 👍 I did notice that we show a different error message on android with empty password or wrong password rather than how in iOS we show Invalid password seen here = https://recordit.co/K8r7qnxUl8
Again this is only on android. To reproduce:
|
ibrahimtaveras00
added
QA'd - Issues Found
andrepimenta
added
needs-qa
|
@ibrahimtaveras00 just fixed the error message on Android 👍 You can take a look again |
ibrahimtaveras00
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Update aes crypto lib working * Working on iOS * init migration * Recreate vault on login and fingerprint * Fix selectedAddress * Add passwordSet again * Fix recreate vault * Improve getting simple key pair accounts * Update tests * Make sure selectedAddress is available * Fix for multiple imported accounts * remove unecessary async await * Rename and remove unecessary code * Using logger now * Check new error on android
11 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration to the current version of aes-crypto lib from the forked one.