Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/hide protect wallet modal #1783

Merged
merged 2 commits into from
Aug 18, 2020
Merged

bugfix/hide protect wallet modal #1783

merged 2 commits into from
Aug 18, 2020

Conversation

estebanmino
Copy link
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner August 18, 2020 19:46
@estebanmino estebanmino added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release labels Aug 18, 2020
andrepimenta
andrepimenta approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 18, 2020
@estebanmino estebanmino merged commit 7b823c0 into develop Aug 18, 2020
@estebanmino estebanmino deleted the bugfix/showProtectWalletModal branch August 18, 2020 21:22
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/hide protect wallet modal (#1783)
52f1e14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @andrepimenta @ibrahimtaveras00