Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proptype warning for WebviewError #1866

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fix proptype warning for WebviewError #1866

merged 1 commit into from
Oct 6, 2020

Conversation

rickycodes
Copy link
Contributor

Description

I see a proptype failure on the WebViewError:

image

this fixes that

this is happening because in the BrowserTab/index.js we're setting the error as a bool here: https://github.com/MetaMask/metamask-mobile/blob/develop/app/components/Views/BrowserTab/index.js#L1229

and then as errorInfo obj here: https://github.com/MetaMask/metamask-mobile/blob/develop/app/components/Views/BrowserTab/index.js#L1418

but in props validation it can only be object

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@rickycodes rickycodes requested a review from a team as a code owner October 1, 2020 04:39
@rickycodes rickycodes force-pushed the bugfix/fix-webview-prop-type-error branch from e824ac5 to 83e7d19 Compare October 3, 2020 17:13
@rickycodes rickycodes added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 6, 2020
estebanmino
estebanmino approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just merge this one

@rickycodes rickycodes force-pushed the bugfix/fix-webview-prop-type-error branch from 83e7d19 to 3ed2f8f Compare October 6, 2020 18:18
@rickycodes rickycodes merged commit 15aae28 into develop Oct 6, 2020
@rickycodes rickycodes deleted the bugfix/fix-webview-prop-type-error branch October 6, 2020 18:41
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Fix proptype warning for WebviewError (#1866)
bbe7ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickycodes @estebanmino