Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Sep 1, 2025

Description

This PR aims to fix recipient validation and ENS resolution in new send flow.

Changelog

CHANGELOG entry:

Related issues

Fixes: #18356

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Contract Token Addresses:
Contract Token Address

Invalid ENS addresses:
Invalid ENS

Burn addresses:
Burn address 1
Burn address 2

Invisible characters:
Screenshot 2025-09-01 at 14 48 00

Confusable characters:
Screenshot 2025-09-01 at 14 54 38

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Sep 1, 2025
@github-actions github-actions bot added the size-S label Sep 1, 2025
@OGPoyraz OGPoyraz changed the title WIP - Fix ENS recipients and recipient validations fix: cp-7.55.0 Fix ENS recipients and recipient validations Sep 1, 2025
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Sep 1, 2025
@github-actions github-actions bot added size-M and removed size-S labels Sep 1, 2025
@OGPoyraz OGPoyraz marked this pull request as ready for review September 1, 2025 12:55
@OGPoyraz OGPoyraz requested a review from a team as a code owner September 1, 2025 12:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: a66bcca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/886562fd-86fb-4dda-a64c-14bcc7578cc8

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bc8391e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00a1fd89-3de9-41aa-b3cf-489a54d9b2e9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

@OGPoyraz OGPoyraz enabled auto-merge September 1, 2025 14:48
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0d57092
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f332eb17-4bbc-44a7-86d7-9adfda545c52

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 52f44cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1416bb62-123a-46cd-983c-fc16d84ab12b

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@OGPoyraz OGPoyraz added No E2E Smoke Needed No QA Needed Apply this label when your PR does not need any QA effort. and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 4, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

@OGPoyraz OGPoyraz added this pull request to the merge queue Sep 4, 2025
Merged via the queue into main with commit 699f76b Sep 4, 2025
65 checks passed
@OGPoyraz OGPoyraz deleted the ogp/18356 branch September 4, 2025 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2025
@metamaskbot metamaskbot added release-7.56.0 Issue or pull request that will be included in release 7.56.0 release-7.55.0 Issue or pull request that will be included in release 7.55.0 and removed release-7.56.0 Issue or pull request that will be included in release 7.56.0 labels Sep 4, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.55.0 on PR. Adding release label release-7.55.0 on PR and removing other release labels(release-7.56.0), as PR was cherry-picked in branch 7.55.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.55.0 Issue or pull request that will be included in release 7.55.0 size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ENS are not handled as expected in send flow

6 participants