feat: remove metametrics and update choose password screen #19077

grvgoel81 · 2025-09-02T11:15:28Z

Description

Remove metametrics: https://consensyssoftware.atlassian.net/browse/SL-128
Update change password screen: https://consensyssoftware.atlassian.net/browse/SL-128

Changelog

CHANGELOG entry: 1) Remove metametrics: https://consensyssoftware.atlassian.net/browse/SL-128
2) Update change password screen: https://consensyssoftware.atlassian.net/browse/SL-128

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

old_flow.mp4

After

New_flow.mp4

Screen.Recording.2025-09-03.at.3.45.30.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-09-02T11:15:36Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-09-03T06:20:45Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e167680
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce85953e-c095-4e0b-bda4-e54aebb18cf0

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-09-03T12:11:34Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 81e5d5f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac99ba87-c7f9-452f-97c1-7d5a3cdc4118

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

himanshuchawla009 · 2025-09-11T15:33:50Z

app/components/hooks/useMetrics/useMetrics.test.tsx

        "createDataDeletionTask": [MockFunction],
        "createEventBuilder": [MockFunction],
        "enable": [MockFunction],
+        "enableSocialLogin": undefined,


why its not a mockFunction like rest ?

cursor · 2025-09-11T16:16:48Z

app/core/Analytics/MetaMetrics.ts

   * @returns Boolean indicating if MetaMetrics is enabled or disabled
   */
-  isEnabled = () => this.enabled;
+  isEnabled = () => this.isSocialLoginEnabled || this.enabled;


Bug: Metrics Enablement Inconsistency

The isEnabled() method now returns true if any metrics (social login or general) are enabled. This change could inadvertently enable all metrics tracking, potentially violating user privacy if a user opted out of general metrics. It also creates an inconsistency where isEnabled() might report metrics are active, but actual event tracking (which still checks only this.enabled) won't occur if only social login metrics are enabled.

We always reset isSocialLoginEnabled to false when user start general (srp) login flow, so it wont create any issues.

Can we add that to the description?

cursor

Bug: Metrics Reporting Inconsistency

The isEnabled() method now combines isSocialLoginEnabled and enabled with an OR operator. This conflates two distinct metrics states, causing isEnabled() to report metrics as active even when regular metrics are disabled. This creates an inconsistency with trackEvent(), which relies solely on this.enabled, resulting in isEnabled() reporting active metrics while no events are actually tracked.

app/core/Analytics/MetaMetrics.ts#L659-L660

metamask-mobile/app/core/Analytics/MetaMetrics.ts

Lines 659 to 660 in 1de40e0

    
              */ 
        
             isEnabled = () => this.isSocialLoginEnabled || this.enabled;

app/core/Analytics/MetaMetrics.ts#L725-L729

metamask-mobile/app/core/Analytics/MetaMetrics.ts

Lines 725 to 729 in 1de40e0

    
              *  .addSensitiveProperties({ sensitiveProp: 'value' }) 
        
              *  .build()); 
        
              * 
        
              * @param event - Analytics event built with {@link MetricsEventBuilder} 
        
              * @param saveDataRecording - param to skip saving the data recording flag (optional)

app/components/Views/ChoosePassword/index.js

cursor · 2025-09-12T06:26:23Z

app/components/Views/ChoosePassword/index.js

    const { loading, isSelected, password, confirmPassword } = this.state;
    const passwordsMatch = password !== '' && password === confirmPassword;
-    const canSubmit = passwordsMatch && isSelected;
+    const canSubmit = passwordsMatch;


Bug: Inconsistent Form Validation and User Experience

The canSubmit logic was simplified, removing the isSelected checkbox requirement from form submission for all users. This creates an inconsistent user experience for SRP users, who see a password recovery warning checkbox that appears required but isn't enforced on submission. Further, onPressCreate's canSubmit check omits the MIN_PASSWORD_LENGTH validation present in renderContent, potentially enabling the submit button when the password is too short.

Additional Locations (1)

app/components/Views/ChoosePassword/index.js#L720-L721

Code outdated

cursor · 2025-09-12T09:26:26Z

app/components/Views/ChoosePassword/index.js

+      canSubmit = passwordsMatch;
+    } else {
+      canSubmit = passwordsMatch && isSelected;
+    }


Bug: OAuth Password Validation Mismatch

The ChoosePassword component has inconsistent password validation for OAuth users. The onPressCreate method's canSubmit check only verifies matching passwords, while the renderContent method's canSubmit for the UI button also requires the minimum password length. This creates a confusing user experience where the button state doesn't accurately reflect submission requirements.

The button activates only after minimum password length condition meets.

sonarqubecloud · 2025-09-12T11:48:58Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

himanshuchawla009

lgtm, some tests are duplicate and needs better description. We can improve it in upcoming PR.

grvgoel81 added 4 commits September 1, 2025 14:37

Update routes in ChangePassword and Login to skip metametrics

dc34a7e

adding TOU check by default for social login users

215a247

mid commit

996239c

Remove TOU, metametrics and update change password screen

959ec70

grvgoel81 self-assigned this Sep 2, 2025

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

252e340

github-actions bot added the size-M label Sep 2, 2025

grvgoel81 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 2, 2025

grvgoel81 added 5 commits September 2, 2025 18:19

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

4bea5cf

update ChoosePassword

479d1b7

update ChoosePassword

5339c3b

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

2518a8a

add common SocialUI flag and used everywhere

e167680

LeVinhGithub added the Run Smoke E2E label Sep 3, 2025

add tests for OnBoardingSheet and Login

1e55a79

github-actions bot added size-L and removed size-M labels Sep 3, 2025

grvgoel81 added 7 commits September 3, 2025 13:37

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

5a088cb

add tests for ChoosePassword

4a966b3

linting error resolved

7226c73

Resolved ramp sdk dependencies and update tests

2274106

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

823c903

update tests in Nav Main

62e864e

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

81e5d5f

grvgoel81 added Run Smoke E2E and removed Run Smoke E2E labels Sep 3, 2025

update tests

9386a7b

resolve metametrics fucntion error

1e9b22b

grvgoel81 dismissed tommasini’s stale review via 1e9b22b September 11, 2025 14:49

update metametrics snapshot

f80b1c7

grvgoel81 added Run Smoke E2E and removed Run Smoke E2E labels Sep 11, 2025

himanshuchawla009 requested changes Sep 11, 2025

View reviewed changes

resolved PR comment

db01722

grvgoel81 requested a review from himanshuchawla009 September 11, 2025 16:15

cursor bot reviewed Sep 11, 2025

View reviewed changes

grvgoel81 added 2 commits September 11, 2025 20:52

Upadte snapshot

d6875c5

Upadte snapshot

1de40e0

cursor bot reviewed Sep 11, 2025

View reviewed changes

Making checkbox optional

abdb82d

cursor bot reviewed Sep 12, 2025

View reviewed changes

app/components/Views/ChoosePassword/index.js Outdated Show resolved Hide resolved

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

7087a10

cursor bot reviewed Sep 12, 2025

View reviewed changes

grvgoel81 added 2 commits September 12, 2025 12:47

Resolve PR comments

6ee5c7a

Add unit tests

ef1a4c1

cursor bot reviewed Sep 12, 2025

View reviewed changes

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

0fa656a

himanshuchawla009 approved these changes Sep 12, 2025

View reviewed changes

chaitanyapotti approved these changes Sep 12, 2025

View reviewed changes

grvgoel81 requested a review from tommasini September 12, 2025 15:17

tommasini approved these changes Sep 13, 2025

View reviewed changes

grvgoel81 added this pull request to the merge queue Sep 13, 2025

Merged via the queue into main with commit 3433826 Sep 13, 2025
86 of 87 checks passed

grvgoel81 deleted the feat-SL-128_remove_metametrics_screen branch September 13, 2025 07:53

github-actions bot locked and limited conversation to collaborators Sep 13, 2025

	*/
	isEnabled = () => this.isSocialLoginEnabled \|\| this.enabled;

	* .addSensitiveProperties({ sensitiveProp: 'value' })
	* .build());
	*
	* @param event - Analytics event built with {@link MetricsEventBuilder}
	* @param saveDataRecording - param to skip saving the data recording flag (optional)

Uh oh!

feat: remove metametrics and update choose password screen #19077

feat: remove metametrics and update choose password screen #19077

Uh oh!

Conversation

grvgoel81 commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 3, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Sep 3, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

himanshuchawla009 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

grvgoel81 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Sep 11, 2025

Choose a reason for hiding this comment

Bug: Metrics Enablement Inconsistency

Uh oh!

grvgoel81 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

tommasini Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Metrics Reporting Inconsistency

Uh oh!

Uh oh!

cursor bot Sep 12, 2025

Choose a reason for hiding this comment

Bug: Inconsistent Form Validation and User Experience

Uh oh!

grvgoel81 Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Sep 12, 2025

Choose a reason for hiding this comment

Bug: OAuth Password Validation Mismatch

Uh oh!

grvgoel81 Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 12, 2025

Quality Gate passed

Uh oh!

himanshuchawla009 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

grvgoel81 commented Sep 2, 2025 •

edited

Loading

github-actions bot commented Sep 3, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Sep 3, 2025 •

edited by metamaskbot

Loading