Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Sep 4, 2025

Description

BIP-44: introduce the unified network selector scoped to an account group (EVM + Solana, BTC later) with support for popular and custom networks, CAIP-19 display, and parity with existing feature flags.

Why
• BIP-44 groups multiple accounts under one “account group.” Users need a single selector that reflects all enabled networks for that group instead of EVM-only.

core PR: MetaMask/core#6499

Changelog

CHANGELOG entry: Added a unified network selector for BIP-44 account groups, showing EVM and Solana networks in one place and supporting custom networks.

Related issues

Fixes:

Manual testing steps

Feature: BIP-44 network selector

  Background:
    Given I have an account group with at least one EVM account and one Solana account enabled
    And popular networks are enabled in settings
    And I am on the wallet home screen

Screenshots/Recordings

Before

After

Screen.Recording.2025-09-05.at.13.49.11.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 76.02339% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.13%. Comparing base (e624efc) to head (e3c8dc7).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/Wallet/index.tsx 38.23% 15 Missing and 6 partials ⚠️
...s/hooks/useNetworkSelection/useNetworkSelection.ts 80.48% 6 Missing and 2 partials ⚠️
app/components/hooks/useCurrentNetworkInfo.ts 12.50% 5 Missing and 2 partials ⚠️
...s/useNetworksByNamespace/useNetworksByNamespace.ts 91.42% 1 Missing and 2 partials ⚠️
...s/UI/NetworkMultiSelector/NetworkMultiSelector.tsx 50.00% 0 Missing and 1 partial ⚠️
...onents/UI/shared/BaseControlBar/BaseControlBar.tsx 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19276      +/-   ##
==========================================
+ Coverage   76.03%   76.13%   +0.09%     
==========================================
  Files        3201     3221      +20     
  Lines       75664    76370     +706     
  Branches    13441    13601     +160     
==========================================
+ Hits        57532    58142     +610     
- Misses      14409    14477      +68     
- Partials     3723     3751      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salimtb salimtb changed the title Feat/bip 44 network selector Feat: bip 44 network selector Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5b99aac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f46e5e63-8234-4fb1-97c1-3cd3ec967f4c

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb changed the title Feat: bip 44 network selector feat: bip 44 network selector Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4d86d65
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d160c34a-9d46-45b6-8870-680989c79f8a

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fa0ad89
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5bfd0cb2-9c0f-4728-8d26-49ffb2a8be35

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e3c8dc7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e05e3e6-9b48-4d64-8850-d5e7ac30c719

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 415c8d4 Sep 9, 2025
168 of 174 checks passed
@salimtb salimtb deleted the feat/bip-44-network-selector branch September 9, 2025 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-XL team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants