feat: marketing opt in API #19653

grvgoel81 · 2025-09-12T09:50:22Z

Description

MarketingOptIn API added: https://consensyssoftware.atlassian.net/browse/SL-154

Changelog

CHANGELOG entry: MarketingOptIn API added: https://consensyssoftware.atlassian.net/browse/SL-154

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

marketing_api.mp4

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…-marketing-API

himanshuchawla009

api integration to fetch existing marketing opt in status is missing

app/components/Views/ChoosePassword/index.js

grvgoel81 · 2025-09-15T06:11:43Z

api integration to fetch existing marketing opt in status is missing

Added get API.

himanshuchawla009

lgtm

sonarqubecloud · 2025-09-15T13:56:08Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
84.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tommasini · 2025-09-15T13:56:37Z

...ettings/Sections/MetaMetricsAndDataCollectionSection/MetaMetricsAndDataCollectionSection.tsx

+    const fetchMarketingStatus = async () => {
+      try {
+        const data = await OAuthService.getMarketingOptInStatus();
+        dispatch(setDataCollectionForMarketing(data.is_opt_in));


Is it possible to get false but the client have stored already a truly value?

We are syncing data both time at the time of updating switch state via update API and at the time of opening page.

ieow · 2025-09-15T12:15:55Z

app/core/OAuthService/OAuthService.ts

      oauthLoginError: null,
    });
  };
+


You might want to create a new service for this?
I dont see these function require data from OauthService class or viceversa.

ieow · 2025-09-15T12:19:48Z

...ettings/Sections/MetaMetricsAndDataCollectionSection/MetaMetricsAndDataCollectionSection.tsx

    dispatch(setDataCollectionForMarketing(value));
+
+    if (isSeedlessOnboardingLoginFlow) {
+      OAuthService.updateMarketingOptInStatus(value).catch((error) => {


You should update the Marketing Status to the server during the submission.
user could tick then untick the check box

grvgoel81 and others added 30 commits September 1, 2025 14:37

Update routes in ChangePassword and Login to skip metametrics

dc34a7e

adding TOU check by default for social login users

215a247

mid commit

996239c

Remove TOU, metametrics and update change password screen

959ec70

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

252e340

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

4bea5cf

update ChoosePassword

479d1b7

update ChoosePassword

5339c3b

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

2518a8a

add common SocialUI flag and used everywhere

e167680

add tests for OnBoardingSheet and Login

1e55a79

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

5a088cb

add tests for ChoosePassword

4a966b3

linting error resolved

7226c73

Resolved ramp sdk dependencies and update tests

2274106

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

823c903

update tests in Nav Main

62e864e

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

81e5d5f

update tests

9386a7b

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

c5738fa

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

a8afb60

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

909f552

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

234c890

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

4c60ba1

Remove env flag and update all components and unit tests

978d078

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

e88bed0

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

b394d35

Merge branch 'main' into feat-SL-128_remove_metametrics_screen

a3317d2

update choose password snapshot

e8f9b2d

Resolved cursor comment

c8fce31

Merge branch 'feat-SL-128_remove_metametrics_screen' into feat-SL-154…

023fcd0

…-marketing-API

Base automatically changed from feat-SL-128_remove_metametrics_screen to main September 13, 2025 07:53

grvgoel81 requested a review from a team as a code owner September 13, 2025 07:53

Merge branch 'main' into feat-SL-154-marketing-API

3ca9963

himanshuchawla009 requested changes Sep 15, 2025

View reviewed changes

app/components/Views/ChoosePassword/index.js Outdated Show resolved Hide resolved

app/components/Views/ChoosePassword/index.js Outdated Show resolved Hide resolved

Resolve PR comments

6191a8f

This comment was marked as outdated.

Sign in to view

finding unit-tests

48a7539

This comment was marked as outdated.

Sign in to view

grvgoel81 added 2 commits September 15, 2025 11:37

Resolved PR comment

f71f697

Add getMarketing API update in settings

6b95c74

This comment was marked as outdated.

Sign in to view

Add Social login user check in get API

cd5d0e0

grvgoel81 enabled auto-merge September 15, 2025 12:59

grvgoel81 requested a review from himanshuchawla009 September 15, 2025 13:06

grvgoel81 added 2 commits September 15, 2025 17:29

code refactor

2bfa019

code refactor

32f834d

himanshuchawla009 approved these changes Sep 15, 2025

View reviewed changes

chaitanyapotti approved these changes Sep 15, 2025

View reviewed changes

tommasini reviewed Sep 15, 2025

View reviewed changes

tommasini approved these changes Sep 15, 2025

View reviewed changes

grvgoel81 added this pull request to the merge queue Sep 15, 2025

ieow reviewed Sep 15, 2025

View reviewed changes

Merged via the queue into main with commit 8e07c3b Sep 15, 2025
87 checks passed

grvgoel81 deleted the feat-SL-154-marketing-API branch September 15, 2025 14:45

github-actions bot locked and limited conversation to collaborators Sep 15, 2025

metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 15, 2025

Uh oh!

feat: marketing opt in API #19653

feat: marketing opt in API #19653

Uh oh!

Conversation

grvgoel81 commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

himanshuchawla009 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

grvgoel81 commented Sep 15, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

himanshuchawla009 left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 15, 2025

Quality Gate passed

Uh oh!

tommasini Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

grvgoel81 Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

ieow Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

ieow Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

grvgoel81 commented Sep 12, 2025 •

edited

Loading

himanshuchawla009 left a comment •

edited

Loading