Skip to content

feat: TAT-1697 update toast component to support animated loading spinner #19715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 14, 2025
Merged

feat: TAT-1697 update toast component to support animated loading spinner #19715

merged 5 commits into from
Sep 14, 2025

Conversation

@Matt561
Copy link
Contributor

@Matt561 Matt561 commented Sep 13, 2025 •
edited
Loading

Description

Changes:

  • Added optional startAccessory prop to Toast component
  • Added animated spinner for inProgress Perps toast variants

Changelog

CHANGELOG entry: added optional startAccessory prop to Toast component
CHANGELOG entry: added animated spinner for inProgress Perps toast variants

Related issues

Fixes: TAT-1682: Reconsider icon for pending orders

Screenshots/Recordings

Before

After

perps_animated_in_progress_toasts_demo.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Matt561 Matt561 added No QA Needed Apply this label when your PR does not need any QA effort. team-perps Perps team labels Sep 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 marked this pull request as ready for review September 13, 2025 20:40
@Matt561 Matt561 requested review from a team as code owners September 13, 2025 20:40
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 13, 2025
@Matt561 Matt561 force-pushed the feat/tat-1697-update-toast-component-to-support-animated-loading-spinner branch from e69f459 to 82cc9f4 Compare September 14, 2025 17:07
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]
cursor bot reviewed Sep 14, 2025
View reviewed changes
app/components/UI/Perps/hooks/usePerpsToasts.tsx
import { OrderDirection } from '../types';
import { formatDurationForDisplay } from '../utils/time';
import { formatPerpsFiat } from '../utils/formatUtils';
import { Spinner } from '@metamask/design-system-react-native/dist/components/temp-components/Spinner/index.cjs';
Copy link

@cursor cursor bot Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Spinner Import Relies on Fragile Design System Path

The Spinner component is imported from a fragile path: @metamask/design-system-react-native/dist/components/temp-components/Spinner/index.cjs. This relies on internal build artifacts (dist/), temporary components (temp-components/), and a .cjs extension, which may break with future design system updates.

Fix in Cursor Fix in Web

@Matt561
Copy link
Contributor Author

Matt561 commented Sep 14, 2025

10.7% Duplication on New Code

The duplication is intentional since we want separate maintainable toast configs.

@Matt561 Matt561 added Run Smoke E2E skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Sep 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 14, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
79.2% Coverage on New Code (required ≥ 80%)
10.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@Matt561 Matt561 enabled auto-merge September 14, 2025 17:50
@Matt561 Matt561 added this pull request to the merge queue Sep 14, 2025
Merged via the queue into main with commit f075fc2 Sep 14, 2025
98 of 99 checks passed
@Matt561 Matt561 deleted the feat/tat-1697-update-toast-component-to-support-animated-loading-spinner branch September 14, 2025 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-earn team-perps Perps team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Matt561 @brianacnguyen @gambinish @metamaskbot