-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: update create account test and add fixture helper to suppress modal #19743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
| }; | ||
|
|
||
| export const withMultichainAccountDetailsEnabled = async ( | ||
| export const withMultichainAccountDetailsEnabledFixtures = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this due to linting rules. Every test needs to use fixtures. We can either use withFixtures or with*Fixtures for any custom implementations
mathieuartu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!



Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist