Skip to content

Conversation

@cmd-ob
Copy link
Contributor

@cmd-ob cmd-ob commented Sep 15, 2025

Description

  • Fixes test which is failing on the pipelines by updating expected Account name and supressing v2 modal

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cmd-ob cmd-ob requested review from a team as code owners September 15, 2025 11:19
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Sep 15, 2025
@sonarqubecloud
Copy link

};

export const withMultichainAccountDetailsEnabled = async (
export const withMultichainAccountDetailsEnabledFixtures = async (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this due to linting rules. Every test needs to use fixtures. We can either use withFixtures or with*Fixtures for any custom implementations

@cmd-ob cmd-ob added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Sep 15, 2025
@cmd-ob cmd-ob enabled auto-merge September 15, 2025 12:24
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmd-ob cmd-ob added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit 07531b9 Sep 15, 2025
103 of 105 checks passed
@cmd-ob cmd-ob deleted the test/fix-create-account branch September 15, 2025 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants