Skip to content

Conversation

@pnarayanaswamy
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Sep 15, 2025
@pnarayanaswamy pnarayanaswamy added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 366033c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8bc89c75-b849-4ec2-8d5e-cc5d0db37a98

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@pnarayanaswamy pnarayanaswamy added run-ios-e2e-smoke Trigger iOS E2E tests on BitRise and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 57539c1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a8467a3-0e0b-4193-94dd-64c62736ddf4

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

@pnarayanaswamy pnarayanaswamy added No QA Needed Apply this label when your PR does not need any QA effort. and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 15, 2025
@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit 7a90c6b Sep 15, 2025
107 of 109 checks passed
@pnarayanaswamy pnarayanaswamy deleted the gns-per-dapp-confirmation branch September 15, 2025 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants