-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: client integration for auxiliaryFunds + requiredAssets support (EIP-7682)
#19965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
auxiliaryFunds + requiredAssets support (EIP-7682)
| isAuxiliaryFundsSupported: (chainId) => | ||
| ALLOWED_BRIDGE_CHAIN_IDS.includes(chainId), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We landed on this as the sole criteria for this check, since the account check occurs using other hooks? I wonder if we should consolidate those hooks? And/or rename this to be more specific to what aspect of auxFunds support this particular value captures -> isAuxiliaryFundsSupportedForChain or something like that?
not blocking here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is where we landed on the checks, as per discussion.
Renaming the hook though would require us to backtrack on the work that's already been released on the previous work here, so I suggest tackling this in a future refactor.
|
@ffmcgee725 we should add something to the PR description indicating that this isn't really used/usable yet but will be wired up soon by @matthewwalsh0 and the confirmations team |



Description
This PR consists in client integration of the
auxiliaryFundsandrequiredAssetscapabilities defined under ERC-7682 to enable auxiliary funds flows.Important: this capability isn't usable yet, but will later be wired up by @MetaMask/confirmations team.
Changelog
CHANGELOG entry: Add
auxiliaryFunds+requiredAssetssupport defined under ERC-7682 (#19965)Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-409
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist