Skip to content

Conversation

@ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Sep 18, 2025

Description

This PR consists in client integration of the auxiliaryFunds and requiredAssets capabilities defined under ERC-7682 to enable auxiliary funds flows.

Important: this capability isn't usable yet, but will later be wired up by @MetaMask/confirmations team.

Changelog

CHANGELOG entry: Add auxiliaryFunds + requiredAssets support defined under ERC-7682 (#19965)

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-409

Manual testing steps

Feature: auxiliaryFunds support

  Scenario: user has wallet permissions
    Given support for EIP 7682 is enabled

    When user requests `wallet_getCapabilities` (via https://metamask.github.io/test-dapp)
    Then `auxiliaryFunds` should be returned as a supported capability

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Sep 18, 2025
@socket-security
Copy link

socket-security bot commented Sep 18, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​eip-5792-middleware@​1.1.0 ⏵ 1.2.0100 +1610076 +391100
Updatednpm/​@​metamask/​transaction-controller@​60.3.0 ⏵ 60.4.098 +110081 +2100 +1100

View full report

@ffmcgee725 ffmcgee725 marked this pull request as ready for review September 19, 2025 09:56
@sonarqubecloud
Copy link

@ffmcgee725 ffmcgee725 changed the title feat: client integration for auxiliaryFunds + requiredAssets support (EIP-7682) feat: client integration for auxiliaryFunds + requiredAssets support (EIP-7682) Sep 19, 2025
Comment on lines +812 to +813
isAuxiliaryFundsSupported: (chainId) =>
ALLOWED_BRIDGE_CHAIN_IDS.includes(chainId),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We landed on this as the sole criteria for this check, since the account check occurs using other hooks? I wonder if we should consolidate those hooks? And/or rename this to be more specific to what aspect of auxFunds support this particular value captures -> isAuxiliaryFundsSupportedForChain or something like that?

not blocking here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is where we landed on the checks, as per discussion.

Renaming the hook though would require us to backtrack on the work that's already been released on the previous work here, so I suggest tackling this in a future refactor.

@adonesky1
Copy link
Contributor

@ffmcgee725 we should add something to the PR description indicating that this isn't really used/usable yet but will be wired up soon by @matthewwalsh0 and the confirmations team

@ffmcgee725 ffmcgee725 added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit 28cf97f Sep 24, 2025
112 of 141 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/WAPI-409 branch September 24, 2025 10:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
@metamaskbot metamaskbot added the release-999.9.0 Issue or pull request that will be included in release 999.9.0 label Sep 24, 2025
@XxdpavelxX XxdpavelxX added release-7.57.0 Issue or pull request that will be included in release 7.57.0 and removed release-999.9.0 Issue or pull request that will be included in release 999.9.0 labels Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-XS team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants