Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 22, 2025

Description

Bumping @metamask/smart-transactions-controller:

## [19.2.0]

### Added

- Add missing constants and helpers exports ([#538](https://github.com/MetaMask/smart-transactions-controller/pull/538))
  - `MetaMetricsEventCategory`
  - `MetaMetricsEventName`
  - `getSmartTransactionMetricsProperties`
  - `getSmartTransactionMetricsSensitiveProperties`

## [19.1.0]

### Added

- Add missing exports for types ([#537](https://github.com/MetaMask/smart-transactions-controller/pull/537))
  - `Fee`
  - `Fees`
  - `IndividualTxFees`
  - `FeatureFlags`
  - `SmartTransactionMinedTx`
  - `SmartTransaction`
  - `SmartTransactionCancellationReason`
  - `SmartTransactionStatuses`
  - `ClientId`

## [19.0.0]

### Added

- This package can now be used in ESM environments as well as CommonJS ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))
- Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](https://github.com/MetaMask/smart-transactions-controller/pull/531))

### Changed

- **BREAKING:** Disallow subpath exports ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))
- **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](https://github.com/MetaMask/smart-transactions-controller/pull/532), [#534](https://github.com/MetaMask/smart-transactions-controller/pull/534))
- **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](https://github.com/MetaMask/smart-transactions-controller/pull/534))
  - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist:
    - `TransactionController:getNonceLock`
    - `TransactionController:confirmExternalTransaction`
    - `TransactionController:getTransactions`
    - `TransactionController:updateTransaction`
- Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](https://github.com/MetaMask/smart-transactions-controller/pull/529))
- Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](https://github.com/MetaMask/smart-transactions-controller/pull/529))

### Removed

- **BREAKING:** Remove default export ([#535](https://github.com/MetaMask/smart-transactions-controller/pull/535))
  - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Upgrades Smart Transactions to ^19.2.1 and Transaction Controller to ^60.4.0, replaces subpath/type imports, migrates Engine/messaging integration, and updates related hooks, views, selectors, and tests.

  • Dependencies:
    • Bump @metamask/smart-transactions-controller to ^19.2.1 and @metamask/transaction-controller to ^60.4.0 (lockfile updated).
  • Engine/Controllers:
    • Switch to named exports from @metamask/smart-transactions-controller; remove default export usage.
    • Migrate STX controller constructor to use messenger actions (TransactionController:getNonceLock, confirmExternalTransaction, getTransactions, updateTransaction) instead of direct callbacks; add MetaMetrics constants/util imports from root.
    • Transaction Controller init: use SmartTransactionStatuses from root; wire STX hooks (single/batch) and metrics/notification handlers; keep pending resubmit disabled.
  • App code updates:
    • Replace all @metamask/smart-transactions-controller/dist/... imports with root package exports (types, enums like SmartTransaction, SmartTransactionStatuses, Fee/Fees).
    • Update Swaps (QuotesView, useSwapsSmartTransaction), UnifiedTransactionsView, SmartTransactionStatus components/tests, NotificationsManager, selectors, migrations, and smart-transactions utils/hooks to new exports.
  • Tests:
    • Adapt tests to new controller exports and messenger permissions for STX hooks; minor Hex import fixes.

Written by Cursor Bugbot for commit 3c62faf. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Sep 22, 2025
@socket-security
Copy link

socket-security bot commented Sep 22, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​smart-transactions-controller@​18.1.0 ⏵ 19.2.198 +210092 +196 -150

View full report

@github-actions github-actions bot added size-M and removed size-S labels Sep 22, 2025
@mikesposito mikesposito marked this pull request as ready for review September 22, 2025 20:16
@mikesposito mikesposito requested review from a team as code owners September 22, 2025 20:16
yarn.lock Outdated
json-stable-stringify-without-jsonify "^1.0.1"
loglevel "^1.9.2"

"@metamask/base-controller@^7.0.1":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Gudahtt
Gudahtt previously approved these changes Sep 22, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt force-pushed the mikesposito/deps/smart-transactions-controller branch from 6add80c to 28ebc07 Compare September 22, 2025 22:07
MarioAslau
MarioAslau previously approved these changes Sep 23, 2025
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bfullam
bfullam previously approved these changes Sep 23, 2025
OGPoyraz
OGPoyraz previously approved these changes Sep 23, 2025
Gudahtt
Gudahtt previously approved these changes Sep 24, 2025
@mikesposito mikesposito requested review from a team as code owners October 2, 2025 08:02
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.62%. Comparing base (ac93700) to head (35d46a3).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20152   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files        3401     3401           
  Lines       83977    83961   -16     
  Branches    15572    15567    -5     
=======================================
- Hits        64345    64333   -12     
+ Misses      15315    15312    -3     
+ Partials     4317     4316    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dan437
dan437 previously approved these changes Oct 7, 2025
Gudahtt
Gudahtt previously approved these changes Oct 7, 2025
cursor[bot]

This comment was marked as outdated.

OGPoyraz
OGPoyraz previously approved these changes Oct 7, 2025
matthewwalsh0
matthewwalsh0 previously approved these changes Oct 7, 2025
@mikesposito mikesposito dismissed stale reviews from matthewwalsh0, OGPoyraz, and Gudahtt via 3c62faf October 7, 2025 13:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

@mikesposito mikesposito added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit f882c82 Oct 7, 2025
113 of 114 checks passed
@mikesposito mikesposito deleted the mikesposito/deps/smart-transactions-controller branch October 7, 2025 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
@metamaskbot metamaskbot added the release-7.58.0 Issue or pull request that will be included in release 7.58.0 label Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.58.0 Issue or pull request that will be included in release 7.58.0 size-M team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.