feat: update notification account settings to use BIP-44 designs #20307

Prithpal-Sooriya · 2025-09-24T10:45:01Z

Description

This reuses the BIP-44 designs for the notification account settings.
I also took this as an opportunity to improve the style and spacing for the notification settings view.

NOTE - once we support multi-SRP notifications, we will probably clean up this settings page. Potentially remove the per account notification settings (notifications will be on all accounts or no accounts)

Changelog

CHANGELOG entry: refactor: cleanup notification account settings to use BIP-44 designs.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-1260

Manual testing steps

Open notification settings (settings > notifications)
See account notification styles.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refactors Notifications settings to use multichain account groups (BIP-44) with AccountCell UI, updates hooks to operate on account IDs/EVM addresses, and adjusts styles and tests/e2e.

Notifications Settings UI (BIP-44)
- Replace per-address UI with multichain account group UI using AccountCell and section header AccountListHeader.
- New endContainer support in AccountCell with BalanceEndContainer for balance/menu; used to render per-account switches.
- Updated styles (NotificationsSettings.styles) to add separators, spacing tweaks, and header layout.
Hooks/Logic
- useNotificationAccountListProps now derives addresses from account IDs, normalizes EVM addresses, and exposes getEvmAddress plus ID-based isAccountLoading/isAccountEnabled.
- Add useFirstHDWalletAccounts and update useAccountProps to return firstHDWalletGroups + avatar type.
Components
- AccountsList now lists firstHDWalletGroups.data, renders NotificationOptionToggle with group item and computed EVM address, and shows a section header.
- NotificationOptionToggle composes AccountCell and renders loading/switch via endContainer.
- AccountListHeader accepts optional containerStyle.
Tests/E2E
- Update unit tests to new account-group model and ID-based APIs; refresh snapshots.
- E2E: add separator test ID and swipe interactions; update selectors and flow.

^{Written by Cursor Bugbot for commit 0e45afd. This will update automatically on new commits. Configure here.}

we still need to update tests and styles, which I'll get to later

github-actions · 2025-09-24T10:45:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…S-1260/notification-account-settings-bip-44-components

github-actions · 2025-09-25T15:21:38Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 957a2c3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/541790f6-d0f1-4279-b4ca-5f55038c7b9d

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-09-29T09:20:41Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5511395
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/99085f57-76b5-407f-9ed4-c0d739d03b74

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

app/components/Views/Settings/NotificationsSettings/AccountsList.test.tsx

app/components/Views/Settings/NotificationsSettings/AccountsList.tsx

sonarqubecloud · 2025-09-29T09:38:13Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

app/component-library/components-temp/MultichainAccounts/AccountCell/AccountCell.tsx

…260/notification-account-settings-bip-44-components

Prithpal-Sooriya · 2025-11-07T11:49:39Z

Had to force-push since this branch was pretty out of date (and the pre-commit to merge hooks were failing).

app/components/Views/Settings/NotificationsSettings/AccountsList.test.tsx

after merging main, some places use other selectors, might as well just provide mock state to our tests

sonarqubecloud · 2025-11-07T13:13:55Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Prithpal-Sooriya · 2025-11-07T13:41:31Z

app/component-library/components-temp/MultichainAccounts/AccountCell/AccountCell.tsx

-              color={TextColor.Alternative}
-            />
-          </TouchableOpacity>
+        {endContainer || (


Modified so we can pass in either a custom component or rely on the existing component. Provides more flexibility.

...emp/MultichainAccounts/MultichainAccountSelectorList/AccountListHeader/AccountListHeader.tsx

app/components/Views/Settings/NotificationsSettings/AccountsList.hooks.test.tsx

e2e/specs/notifications/notification-settings-flow.spec.ts

ccharly

LGTM for accounts owned files (not tested)

ccharly · 2025-11-07T15:43:22Z

app/component-library/components-temp/MultichainAccounts/AccountCell/AccountCell.tsx

-              color={TextColor.Alternative}
-            />
-          </TouchableOpacity>
+        {endContainer || (


Nit: I guess ?? would have been a bit more appropriate, but I'm ok with the || too 😁

Haha good callout. Emm might visit this later since I have approvals 🤪

I've tested this feature with the team 👍🏾

vinnyhoward

LGTM

feat: update notification account settings to use BIP-44 designs

9c84627

we still need to update tests and styles, which I'll get to later

metamaskbot added the team-assets label Sep 24, 2025

github-actions bot added the size-M label Sep 24, 2025

test: fix UTs

926eab1

github-actions bot added size-L and removed size-M labels Sep 24, 2025

Prithpal-Sooriya added 4 commits September 24, 2025 15:20

style: improve notification setting styling

b8f76b4

Merge branch 'main' of github.com:MetaMask/metamask-mobile into ASSET…

9269693

…S-1260/notification-account-settings-bip-44-components

test: update UTs

b12a6d3

Merge branch 'main' of github.com:MetaMask/metamask-mobile into ASSET…

957a2c3

…S-1260/notification-account-settings-bip-44-components

Prithpal-Sooriya added the run-ios-e2e-smoke Trigger iOS E2E tests on BitRise label Sep 25, 2025

test: update e2e notification tests

d641cb1

This comment was marked as spam.

Sign in to view

Prithpal-Sooriya added run-ios-e2e-smoke Trigger iOS E2E tests on BitRise and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 29, 2025

Prithpal-Sooriya marked this pull request as ready for review September 29, 2025 09:20

Prithpal-Sooriya requested review from a team as code owners September 29, 2025 09:20

cursor bot reviewed Sep 29, 2025

View reviewed changes

app/components/Views/Settings/NotificationsSettings/AccountsList.test.tsx Show resolved Hide resolved

app/components/Views/Settings/NotificationsSettings/AccountsList.tsx Show resolved Hide resolved

metamaskbot added the bitrise-result-ready label Sep 29, 2025

github-actions bot removed the bitrise-result-ready label Sep 29, 2025

bergarces reviewed Sep 30, 2025

View reviewed changes

app/component-library/components-temp/MultichainAccounts/AccountCell/AccountCell.tsx Outdated Show resolved Hide resolved

bergarces previously approved these changes Sep 30, 2025

View reviewed changes

cortisiko previously approved these changes Oct 21, 2025

View reviewed changes

Prithpal-Sooriya added 6 commits November 7, 2025 11:32

Merge commit '9c84627ea8fd82308ef8760769dd3c5a37fde5ed' into ASSETS-1…

a9574bd

…260/notification-account-settings-bip-44-components

Merge commit '926eab185affd3a741bb87242ed4261e7a569823' into ASSETS-1…

a88a088

…260/notification-account-settings-bip-44-components

Merge commit 'b8f76b458aea1ba267240113eaff1be1396b5bd8' into ASSETS-1…

7d58f71

…260/notification-account-settings-bip-44-components

Merge commit 'b12a6d38cb246f68b79bf01319f41291acb290cd' into ASSETS-1…

96be66a

…260/notification-account-settings-bip-44-components

Merge commit 'd641cb1f3c6b28dbc6f84cc1d33080c0157d7b9d' into ASSETS-1…

48fc651

…260/notification-account-settings-bip-44-components

chore: fix lint issues from merge conflicts

fbf39c0

Prithpal-Sooriya dismissed stale reviews from cortisiko and bergarces via fbf39c0 November 7, 2025 11:40

Prithpal-Sooriya force-pushed the ASSETS-1260/notification-account-settings-bip-44-components branch from 5511395 to fbf39c0 Compare November 7, 2025 11:40

chore: remove todo comment

bba3019

cursor bot reviewed Nov 7, 2025

View reviewed changes

app/components/Views/Settings/NotificationsSettings/AccountsList.test.tsx Show resolved Hide resolved

chore: fix UTs

0e45afd

after merging main, some places use other selectors, might as well just provide mock state to our tests

Prithpal-Sooriya commented Nov 7, 2025

View reviewed changes

...emp/MultichainAccounts/MultichainAccountSelectorList/AccountListHeader/AccountListHeader.tsx Show resolved Hide resolved

Prithpal-Sooriya commented Nov 7, 2025

View reviewed changes

app/components/Views/Settings/NotificationsSettings/AccountsList.hooks.test.tsx Show resolved Hide resolved

Prithpal-Sooriya commented Nov 7, 2025

View reviewed changes

e2e/specs/notifications/notification-settings-flow.spec.ts Show resolved Hide resolved

bergarces approved these changes Nov 7, 2025

View reviewed changes

ccharly approved these changes Nov 7, 2025

View reviewed changes

Prithpal-Sooriya enabled auto-merge November 7, 2025 15:48

vinnyhoward approved these changes Nov 7, 2025

View reviewed changes

christopherferreira9 approved these changes Nov 10, 2025

View reviewed changes

Prithpal-Sooriya added this pull request to the merge queue Nov 10, 2025

Merged via the queue into main with commit 1623d46 Nov 10, 2025
87 checks passed

Prithpal-Sooriya deleted the ASSETS-1260/notification-account-settings-bip-44-components branch November 10, 2025 16:32

github-actions bot locked and limited conversation to collaborators Nov 10, 2025

metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 10, 2025

Uh oh!

feat: update notification account settings to use BIP-44 designs #20307

feat: update notification account settings to use BIP-44 designs #20307

Conversation

Prithpal-Sooriya commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 25, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as spam.

github-actions bot commented Sep 29, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 29, 2025

Quality Gate passed

Uh oh!

Uh oh!

Prithpal-Sooriya commented Nov 7, 2025

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 7, 2025

Quality Gate passed

Uh oh!

Prithpal-Sooriya Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccharly left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ccharly Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Prithpal-Sooriya Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

vinnyhoward left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Prithpal-Sooriya commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Sep 29, 2025 •

edited by metamaskbot

Loading

ccharly left a comment •

edited

Loading