-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: existing EVM permissions removed when a Solana Wallet Standard connection is rejected #20309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+56
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
wenfix
previously approved these changes
Sep 24, 2025
Contributor
wenfix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wenfix
previously approved these changes
Sep 24, 2025
|
wenfix
approved these changes
Sep 25, 2025
auto-merge was automatically disabled
September 25, 2025 08:57
Pull Request is not mergeable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.57.0
Issue or pull request that will be included in release 7.57.0
size-XS
team-wallet-api-platform-deprecated
DEPRECATED: please use "team-wallet-integrations" instead
team-wallet-integrations
Wallet Integrations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
When a dapp connects to MetaMask via EVM and the user rejects a subsequent connection request for SVM, the existing EVM connection is closed. This can potentially break dapp flows and edge cases where maintaining the EVM connection is critical.
To fix this, we implemented partial revoking into the
wallet_revokeSessionhandler on MetaMask/core#6668 so that we can then update our solana wallet-standard provider would only revoke the solana scopes when it is asked to disconnect, here MetaMask/solana-wallet-standard#53.This PR bumps all necessary packages for this to take place, fixing the undesired EVM permissions revoke when a solana wallet standard connection is refused.
Changelog
CHANGELOG entry: Fixes existing EVM permissions removed when a Solana Wallet Standard connection is rejected
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-413
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist