Skip to content

Conversation

@ffmcgee725
Copy link
Member

Description

When a dapp connects to MetaMask via EVM and the user rejects a subsequent connection request for SVM, the existing EVM connection is closed. This can potentially break dapp flows and edge cases where maintaining the EVM connection is critical.

To fix this, we implemented partial revoking into the wallet_revokeSession handler on MetaMask/core#6668 so that we can then update our solana wallet-standard provider would only revoke the solana scopes when it is asked to disconnect, here MetaMask/solana-wallet-standard#53.

This PR bumps all necessary packages for this to take place, fixing the undesired EVM permissions revoke when a solana wallet standard connection is refused.

Changelog

CHANGELOG entry: Fixes existing EVM permissions removed when a Solana Wallet Standard connection is rejected

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-413

Manual testing steps

Feature: fix EVM permmissions removed when Solana Wallet Standard connection rejected

  Scenario: user rejects Solana Wallet Standard connection
    Given there are existing EVM permissions for the dapp

    When user rejects Solana Wallet Standard connection
    Then EVM permissions should still exist, and not be revoked

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Sep 24, 2025
@ffmcgee725 ffmcgee725 added the team-wallet-integrations Wallet Integrations team label Sep 24, 2025
@socket-security
Copy link

socket-security bot commented Sep 24, 2025

wenfix
wenfix previously approved these changes Sep 24, 2025
Copy link
Contributor

@wenfix wenfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wenfix
wenfix previously approved these changes Sep 24, 2025
@sonarqubecloud
Copy link

@ffmcgee725 ffmcgee725 added this pull request to the merge queue Sep 25, 2025
auto-merge was automatically disabled September 25, 2025 08:57

Pull Request is not mergeable

Merged via the queue into main with commit 6514e93 Sep 25, 2025
106 of 107 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/WAPI-728 branch September 25, 2025 09:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-XS team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead team-wallet-integrations Wallet Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants