Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detox: Update RPC and Browser Tests #2149

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Detox: Update RPC and Browser Tests #2149

merged 2 commits into from
Jan 20, 2021

Conversation

ibrahimtaveras00
Copy link
Contributor

Browser Tests:

Add custom RPC tests:

  • chainID is required now, so I added that

@ibrahimtaveras00 ibrahimtaveras00 requested a review from a team as a code owner January 20, 2021 22:06
estebanmino
estebanmino approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ibrahimtaveras00 ibrahimtaveras00 merged commit 825816a into develop Jan 20, 2021
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox/update-RPC-and-browser-tests branch January 20, 2021 22:14
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@ibrahimtaveras00 @estebanmino
update tests for new logic (#2149)
94f5bf0 
Co-authored-by: Ibrahim Taveras <ibrahimtaveras@Ibrahims-MacBook-Pro.local>
Co-authored-by: Esteban Miño <efmino@uc.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibrahimtaveras00 @estebanmino