-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: Consolidate E2E commands and enable dynamic debug/release configuration for Android #21530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
98316be to
27c4a6f
Compare
This reverts commit 5364b93.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21530 +/- ##
==========================================
+ Coverage 77.04% 77.07% +0.02%
==========================================
Files 3765 3767 +2
Lines 95826 95853 +27
Branches 18616 18622 +6
==========================================
+ Hits 73833 73874 +41
+ Misses 16918 16906 -12
+ Partials 5075 5073 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/respect-js-env-build-variants
06828ff to
cb8faa3
Compare
|



Description
This change aims to resolve some bottlenecks associated with hardcoded environment build types and environments especially when running the watcher locally. This is causing much confusion since devs have reported that METAMASK_BUILD_TYPE and METAMASK_ENVIRONMENT is not being picked up when switching between variants such as main and flask. Furthermore, these issues impacts E2E as well (especially flask build setup), which continues to introduce friction as CI continues to migrate to Github CI.
Changelog
CHANGELOG entry:
Related issues
Fixes: #21682
Manual testing steps
Screenshots/Recordings
Before
After
watcher mode with both METAMASK_BUILD_TYPE and METAMASK_ENVIRONMENT specified

watcher mode without METAMASK_BUILD_TYPE and METAMASK_ENVIRONMENT

using

start:ios, which hardcodes platform=ios, buildtype=main, environment=devusing

test:e2e:android:flask:build, which hardcodes platform=android, buildtype=flask, environment=e2eexpo_dev_pipeline - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a9dc5979-790d-411c-b823-f3295abb9d28
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Unifies E2E build/run across scripts, Detox, Bitrise, and docs with dynamic Debug/Release via CONFIGURATION, prebuilt artifact support, new iOS/Flask CI configs, and removal of legacy workflows.
scripts/build.shto sourceMETAMASK_BUILD_TYPE/METAMASK_ENVIRONMENT(except watcher), validate inputs, and print unified titles.generateAndroidBinaryfor flavor/config builds; remove legacy per-variant dev/E2E builders; standardize Sentry property handling.COMMAND_YARNandCONFIGURATION(Debug/Release); add/share intermediate artifacts; adjust renaming/deploy steps.CONFIGURATION='Release'to main Android workflows; simplify build scripts; remove deprecated Flask QA/beta paths and redundant workflows.yarn test:e2e:*:$METAMASK_BUILD_TYPE:ci; improve caching and artifact sharing.CONFIGURATIONin build commands.ios.sim.main.citoios.main.release; addios.sim.flask.ci.testBinaryPathsupport.package.json):watchscripts; remove start-e2e variants.test:e2e:ios:flask:ci; setBRIDGE_USE_DEV_APIS=truefor Flask E2E builds; addbuild:android:checksum:prod..e2e.env, watcher usage, and hardcoded build types; revise Flask sections to usetest:e2e:*:flask:*commands and troubleshooting.app/core/DeeplinkManager,scripts/build.sh, andhandlePerpsUrl.tsunder Perps.Written by Cursor Bugbot for commit cb8faa3. This will update automatically on new commits. Configure here.