Skip to content

Conversation

@christopherferreira9
Copy link
Contributor

@christopherferreira9 christopherferreira9 commented Oct 27, 2025

Description

This PR refactors e2eBridgePerps to use the CommandQueueServer polling instead of deeplinks.
All references to deeplinks in this context were kept.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Switches Perps E2E control from deeplinks to an HTTP-polled CommandQueueServer queue and updates helpers/specs to enqueue commands.

  • E2E Bridge (Perps):
    • Add HTTP polling with axios to read commands from http://<host>:<port>/queue.json (and /debug.json) and apply push-price, force-liquidation, and mock-deposit via the Perps mock service.
    • Start polling during autoConfigureE2EBridge; retain lightweight deeplink handler as fallback.
  • E2E Framework:
    • e2e/framework/fixtures/CommandQueueServer.ts: export CommandQueueItem; add GET /debug.json (non-destructive) alongside existing GET /queue.json (clears queue).
  • Test Helpers:
    • e2e/specs/perps/helpers/perps-modifiers.ts: add server-backed methods (updateMarketPriceServer, triggerLiquidationServer, applyDepositUSDServer) that enqueue PerpsModifiersCommandTypes; keep deeplink methods.
  • Specs:
    • e2e/specs/perps/perps-add-funds.spec.ts: use TestSuiteParams.commandQueueServer and switch deposit mock to applyDepositUSDServer.

Written by Cursor Bugbot for commit 9e3a527. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested review from a team as code owners October 27, 2025 15:01
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 27, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Oct 27, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@christopherferreira9 christopherferreira9 merged commit 9bd6fcb into e2e-perps-add-funds Oct 28, 2025
37 of 51 checks passed
@christopherferreira9 christopherferreira9 deleted the christopher/update-e2eBridgePerps-server branch October 28, 2025 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants