-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(perps): remove hardcoded color in RefreshControl #21916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21916 +/- ##
==========================================
+ Coverage 77.04% 77.06% +0.02%
==========================================
Files 3765 3767 +2
Lines 95826 95863 +37
Branches 18616 18623 +7
==========================================
+ Hits 73833 73881 +48
+ Misses 16918 16909 -9
+ Partials 5075 5073 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abretonc7s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably need to remove tintColor
|
@abretonc7s that's now updated |
|



Description
This PR removes custom color styling from RefreshControl components in the Perps feature area. The colors prop (or tintColor prop) was previously set to theme.colors.icon.default, which could cause visual inconsistencies when the user uses dark theme. By removing this custom color configuration, the RefreshControl now uses the native system defaults
Changelog
CHANGELOG entry: Fixed RefreshControl color styling in Perps views to use native system defaults
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1568
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes theme-based color overrides from
RefreshControlin Perps Market Details and drops the now-unusedthemefromuseStyles.app/components/UI/Perps/Views/PerpsMarketDetailsView/PerpsMarketDetailsView.tsx):tintColor/colorstheme overrides; now uses system defaults via<RefreshControl refreshing={refreshing} onRefresh={handleRefresh} />.themefromuseStylesdestructure (const { styles } = useStyles(createStyles, {});).Written by Cursor Bugbot for commit 95ae927. This will update automatically on new commits. Configure here.