Skip to content

Conversation

@michalconsensys
Copy link
Contributor

@michalconsensys michalconsensys commented Oct 30, 2025

Description

This PR removes custom color styling from RefreshControl components in the Perps feature area. The colors prop (or tintColor prop) was previously set to theme.colors.icon.default, which could cause visual inconsistencies when the user uses dark theme. By removing this custom color configuration, the RefreshControl now uses the native system defaults

Changelog

CHANGELOG entry: Fixed RefreshControl color styling in Perps views to use native system defaults

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1568

Manual testing steps

Feature: RefreshControl styling in Perps views

  Scenario: user performs pull-to-refresh on Perps Market Details
    Given user is on the Perps Market Details view
    And the user is using dark mode on Android
    
    When user performs a pull-to-refresh gesture
    Then the refresh indicator should display with native system colors
    And the refresh indicator should be visible and properly styled
    And data should refresh successfully

Screenshots/Recordings

Before

Capture d’écran 2025-09-16 à 12 23 17

After

Screenshot_1761822745

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes theme-based color overrides from RefreshControl in Perps Market Details and drops the now-unused theme from useStyles.

  • Perps Market Details (app/components/UI/Perps/Views/PerpsMarketDetailsView/PerpsMarketDetailsView.tsx):
    • RefreshControl: Removed tintColor/colors theme overrides; now uses system defaults via <RefreshControl refreshing={refreshing} onRefresh={handleRefresh} />.
    • Styles hook: Dropped unused theme from useStyles destructure (const { styles } = useStyles(createStyles, {});).

Written by Cursor Bugbot for commit 95ae927. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (744b8ce) to head (95ae927).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21916      +/-   ##
==========================================
+ Coverage   77.04%   77.06%   +0.02%     
==========================================
  Files        3765     3767       +2     
  Lines       95826    95863      +37     
  Branches    18616    18623       +7     
==========================================
+ Hits        73833    73881      +48     
+ Misses      16918    16909       -9     
+ Partials     5075     5073       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michalconsensys michalconsensys marked this pull request as ready for review October 30, 2025 12:58
@michalconsensys michalconsensys requested a review from a team as a code owner October 30, 2025 12:58
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-XS and removed size-S labels Oct 30, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to remove tintColor

@michalconsensys
Copy link
Contributor Author

@abretonc7s that's now updated

@sonarqubecloud
Copy link

@gambinish gambinish enabled auto-merge October 31, 2025 17:49
@gambinish gambinish added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit 867e438 Oct 31, 2025
148 of 150 checks passed
@gambinish gambinish deleted the fix/perps/refresh-colors branch October 31, 2025 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-XS team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants