Skip to content

Conversation

@cortisiko
Copy link
Member

@cortisiko cortisiko commented Oct 30, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Polygon/EIP-7702 and transaction-sentinel mocks, refactors Polymarket mocks (cash-out, RPC, event details), and updates/extends E2E tests including a withdraw spec scaffold.

  • Feature flags
    • Add Polygon (0x89) entries to confirmations_eip_7702.contracts and extend supportedChains.
  • Polymarket mocks
    • EIP-7702/Polygon support: Add POLYGON_EIP7702_CONTRACT_ADDRESS and EIP7702_CODE_FORMAT; return EIP-7702 code for eth_getCode of USER_WALLET_ADDRESS.
    • Transaction Sentinel: New polymarket-transaction-sentinel-response.ts and POLYMARKET_TRANSACTION_SENTINEL_MOCKS for infura_simulateTransactions.
    • RPC enhancements: Broaden /proxy matcher; handle proxy wallet eth_call selector 0xaffed0e0; add eth_getTransactionCount and eth_estimateGas responses.
    • Cash-out flow: Consolidate into POLYMARKET_POST_CASH_OUT_MOCKS (mocks CLOB order, updates USDC balance, high-priority balance refresh); deprecate POLYMARKET_CASH_OUT_BALANCE_LOAD_MOCKS; add POLYMARKET_WITHDRAW_BALANCE_LOAD_MOCKS; helper MOCK_BATCH_TRANSACTIONS.
    • Event details: Rename default event export to POLYMARKET_EVENT_DETAILS_BLUE_JAYS_MARINERS_RESPONSE; add/export POLYMARKET_EVENT_DETAILS_SPURS_PELICANS_RESPONSE; update mocks to use them.
    • RPC responses: Add TRANSACTION_COUNT_RESULT.
  • E2E tests
    • Update predict-cash-out.spec.ts to use new cash-out mocks and remove force-refresh mock.
    • Add predict-withdraw.spec.ts (withdraw flow scaffold) using new mocks.

Written by Cursor Bugbot for commit c6301fd. This will update automatically on new commits. Configure here.

@cortisiko cortisiko requested a review from hjetpoluru October 30, 2025 20:24
@cortisiko cortisiko self-assigned this Oct 30, 2025
@cortisiko cortisiko requested a review from a team as a code owner October 30, 2025 20:24
@metamaskbot metamaskbot added the team-qa QA team label Oct 30, 2025
hjetpoluru
hjetpoluru previously approved these changes Oct 30, 2025
@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Oct 30, 2025
@cortisiko cortisiko enabled auto-merge October 30, 2025 20:28
cursor[bot]

This comment was marked as outdated.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (744b8ce) to head (ecebbe4).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21962      +/-   ##
==========================================
+ Coverage   77.04%   77.06%   +0.02%     
==========================================
  Files        3765     3767       +2     
  Lines       95826    95853      +27     
  Branches    18616    18622       +6     
==========================================
+ Hits        73833    73873      +40     
+ Misses      16918    16906      -12     
+ Partials     5075     5074       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added size-XL and removed size-L labels Oct 31, 2025
@sonarqubecloud
Copy link

@hjetpoluru hjetpoluru self-requested a review October 31, 2025 12:49
@cortisiko cortisiko added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit 4748bdc Oct 31, 2025
143 of 150 checks passed
@cortisiko cortisiko deleted the e2e/add-predict-batch-txns-mock branch October 31, 2025 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-XL team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants