Skip to content

Conversation

@abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Oct 31, 2025

Description

This PR fixes an issue where HIP-3 markets (stocks and commodities) with $0.00 volume were incorrectly displayed in the Market List View and Home View.

What was the problem?

  • Markets with zero or invalid volume data were showing up in the Stocks and Commodities tabs
  • This was inconsistent with how crypto perps markets behave (they correctly hide zero-volume markets)

What is the solution?

  • Zero-volume markets are now filtered out consistently across all market types
  • Filtering logic moved to the data layer for consistency
  • Both Market List View and Home View now hide markets with $0.00 volume by default

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1957

Manual testing steps

Feature: Hide zero-volume HIP-3 markets

  Scenario: user views Market List View stocks tab
    Given app is running and Perps feature is enabled

    When user navigates to Market List View
    And user selects the "Stocks" tab
    Then user should only see stocks with valid volume data
    And user should NOT see any markets displaying "$0.00" volume

  Scenario: user views Market List View commodities tab
    Given app is running and Perps feature is enabled

    When user navigates to Market List View
    And user selects the "Commodities" tab
    Then user should only see commodities with valid volume data
    And user should NOT see any markets displaying "$0.00" volume

  Scenario: user views Perps Home View
    Given app is running and Perps feature is enabled

    When user navigates to Perps Home View
    Then user should only see markets with valid volume data in all carousels
    And user should NOT see any markets displaying "$0.00" volume

Screenshots/Recordings

Before

Markets with $0.00 volume were visible in the Stocks tab and other HIP-3 market tabs.

After

Only markets with valid volume data are displayed. Zero-volume markets are filtered out consistently.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Overhauls Perps Markets and Home with searchable/sortable tabs, consistent zero‑volume filtering, bulk Close/Cancel All flows, market hours banner/tooltip, refined leverage priority, and extensive hook/test updates.

  • UI/Navigation:
    • Home: New PerpsHomeView with positions/orders sections, watchlist, market type sections, navigation card, and bottom sheets for Close All/Cancel All.
    • Market List: Reworked PerpsMarketListView with tabs (All/Crypto/Stocks & Commodities), search header, sorting/filters, and reusable PerpsMarketList/row components.
    • Bulk Actions: Added PerpsCloseAllPositionsView/PerpsCancelAllOrdersView and modal variants; shared PerpsCloseSummary.
    • Market Hours: Added PerpsMarketHoursBanner and bottom-sheet tooltip content.
  • Hooks/Logic:
    • Data: New usePerpsHomeData, usePerpsMarketListView, usePerpsSearch, usePerpsSorting; consistent zero‑volume filtering moved to usePerpsMarkets (opt‑in via showZeroVolume).
    • Bulk Ops: usePerpsCloseAllCalculations, usePerpsCloseAllPositions, usePerpsCancelAllOrders for fees/points and execution.
    • Streams: usePerpsLiveFills now returns { fills, isInitialLoading }.
    • Orders: Leverage priority: nav param > existing position > saved config > default; validation accepts existingPositionLeverage.
  • Routing/Styles/Locale:
    • Wired Home and modal routes; various style tweaks; added i18n for market hours.
  • Tests: Extensive new unit tests across views, hooks, components, and styles.

Written by Cursor Bugbot for commit c712e48. This will update automatically on new commits. Configure here.

@abretonc7s abretonc7s requested a review from a team as a code owner October 31, 2025 01:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added the team-perps Perps team label Oct 31, 2025
@abretonc7s abretonc7s changed the title feat(perps): abolity to show market without volume in dev feat(perps): show hip-3 markets without volume in dev Oct 31, 2025
@abretonc7s abretonc7s changed the base branch from main to perps/feat/newhome-nick October 31, 2025 01:42
@abretonc7s abretonc7s added the DO-NOT-MERGE Pull requests that should not be merged label Oct 31, 2025
@sonarqubecloud
Copy link

@abretonc7s abretonc7s merged commit 23eb4a0 into perps/feat/newhome-nick Oct 31, 2025
114 of 115 checks passed
@abretonc7s abretonc7s deleted the feat/hip3-novolume branch October 31, 2025 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@abretonc7s abretonc7s removed DO-NOT-MERGE Pull requests that should not be merged team-earn labels Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants