Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Nov 3, 2025

Description

This PR aims to make burn/null address sending alert to be a blocking alert.

See the task details for further information

Changelog

CHANGELOG entry: Make burn and null address sending a blocking alert

Related issues

Fixes: #22046

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Make burn/null address alerts blocking and update tests accordingly.

  • Alerts:
    • useBurnAddressAlert: Set isBlocking: true for BurnAddress alert in Severity.Danger.
  • Tests:
    • Update useBurnAddressAlert.test.ts to expect isBlocking: true for burn/null address cases (direct and nested recipients, mixed/uppercase casing).

Written by Cursor Bugbot for commit 9093654. This will update automatically on new commits. Configure here.

@OGPoyraz OGPoyraz requested a review from a team as a code owner November 3, 2025 09:03
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@OGPoyraz OGPoyraz added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit b8a8f61 Nov 3, 2025
89 checks passed
@OGPoyraz OGPoyraz deleted the ogp/block-burn-address-send branch November 3, 2025 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make burn address alert blocking

5 participants