Skip to content

Conversation

@cmd-ob
Copy link
Contributor

@cmd-ob cmd-ob commented Nov 3, 2025

Description

  • Add option to wait for the confirm button to disappear on Android, addressing cases where the button may be obscured, this should force and error and cause the action to be retried

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates the e2e confirm action to wait for the confirm button to disappear on Android before proceeding.

  • E2E / Browser Confirmations
    • e2e/pages/Browser/Confirmations/FooterActions.ts
      • Update tapConfirmButton() to pass waitForElementToDisappear (Android-only) to Gestures.waitAndTap.

Written by Cursor Bugbot for commit f51e416. This will update automatically on new commits. Configure here.

@cmd-ob cmd-ob requested a review from a team as a code owner November 3, 2025 13:21
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Nov 3, 2025
@cmd-ob cmd-ob changed the title fix: Add waitForElementToDisappear option for confirm button test: Add waitForElementToDisappear option for confirm button Nov 3, 2025
@cmd-ob cmd-ob added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@cmd-ob cmd-ob enabled auto-merge November 3, 2025 14:02
@cmd-ob cmd-ob added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit c0e1a90 Nov 3, 2025
105 of 110 checks passed
@cmd-ob cmd-ob deleted the e2e/fix-false-confirm-tap branch November 3, 2025 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants