fix(card): delegation issues

[Brunonascdev]

Description

This PR addresses several issues affecting the Card experience, ensuring proper asset display, navigation flow, and data consistency across components.

Fixes

• Fixed an issue where assets were not loading correctly after opening the Card Home screen.
• Corrected balance handling on the Change Asset Bottom Sheet — it now displays availableBalance for enabled tokens and the user’s total balance for disabled ones.
• Restored asset icons on all asset-related bottom sheets.
• Fixed incorrect titles on the Spending Limit screen:
  • Selecting a token that isn’t enabled now correctly shows “Change token and network.”
  • Pressing “Manage spending limit” on Card Home now correctly shows “Enable token.”
• Resolved concurrency issues caused by promise caching in the useLoadCardData hook.

Changelog

CHANGELOG entry: Fixed issue where assets failed to load after opening the Card Home screen.
CHANGELOG entry: Fixed balance display on the Change Asset Bottom Sheet to correctly show availableBalance for enabled tokens and user balance for disabled tokens.
CHANGELOG entry: Restored missing asset icons on asset bottom sheets.
CHANGELOG entry: Fixed incorrect Spending Limit title when selecting a token that’s not enabled (now shows “Change token and network”).
CHANGELOG entry: Fixed incorrect Spending Limit title when pressing “Manage spending limit” on Card Home (now shows “Enable token”).
CHANGELOG entry: Resolved concurrency and caching issues in useLoadCardData hook.

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Replaces balance logic with aggregated hook, adds pull-to-refresh and spending limit progress/warning on Card Home, fixes navigation/metrics/caching, strengthens delegation/external wallet flows, and adds extensive tests.

• Card Home UI:
  • Add pull-to-refresh and toast on enable-card failure.
  • Show Spending Limit progress bar and close-to-limit warning; hide controls when enabling assets/card.
  • Use balanceFormatted fallback when fiat unavailable; update metrics gating and properties.
• Asset Selection / Spending Limit:
  • Use useAssetBalances with per-token keying; show correct balances (available vs wallet), restore icons, exclude Solana where needed.
  • Adjust manage flow routing/params and block navigation during delegation; improved input validation and button states.
• Hooks & Data Flow:
  • Replace useAssetBalance/useAssetsList with useAssetBalances (map-based, multi-token).
  • Revise useLoadCardData with explicit (re)fetch controls, cache-clearing on auth errors, and concurrency fixes.
  • New hooks/util: delegation handling (user-cancel aware), external wallet details with timeout, delegation settings caching, chain/name mapping, safe chainId formatting.
• SDK:
  • Simplify provider init; add allowance querying robustness (skip non-EVM, timeout) and remove unused mapping.
• State & i18n:
  • Add global cache clear on logout; new error string for enable-card.
• Tests:
  • Add/expand tests for AssetSelectionBottomSheet, SpendingLimit, CardHome, delegation, balances, external wallet details, delegation settings, priority token loading, and utilities; update snapshots.

^{Written by Cursor Bugbot for commit 2f10229. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Bug: NaN Propagates Through Number Formatting Edgecase

If parseFloat() receives an invalid balance string, it returns NaN. This can cause toFixed(6) to either display "NaN" in the UI or throw a TypeError when attempting to format the invalid number.

Additional Locations (1)

• app/components/UI/Card/components/AssetSelectionBottomSheet/AssetSelectionBottomSheet.tsx#L420-L421

 

[sonarqubecloud]

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud