Skip to content

Conversation

@cortisiko
Copy link
Member

@cortisiko cortisiko commented Nov 3, 2025

Description

This PR adds assertions to claim flow

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds mocks to surface REDEEM activity after claiming and updates e2e to verify activity details, amounts, and balance refresh.

  • Mocks (Polymarket):
    • Add POLYMARKET_CLAIMED_POSITIONS_ACTIVITY_RESPONSE and new helper POLYMARKET_ADD_CLAIMED_POSITIONS_TO_ACTIVITY_MOCKS to prepend REDEEM transactions to activity.
    • Wire new activity mock into claim flow; keep resolved positions empty post-claim and refresh USDC balance.
  • E2E Tests:
    • Update predict-claim-positions.spec.ts to verify claim button disappears, navigate to Activity → Predictions, open each claimed item, and assert formatted amounts; verify wallet balance on iOS.
    • Adjust synchronization handling and mock sequencing in the claim flow.
  • Page Objects:
    • Add amountDisplay getter to predictionsActivityDetails for asserting displayed amounts.

Written by Cursor Bugbot for commit d77f5ec. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-qa QA team label Nov 3, 2025
@github-actions github-actions bot added the size-M label Nov 3, 2025
@cortisiko cortisiko marked this pull request as ready for review November 3, 2025 22:55
@cortisiko cortisiko requested a review from a team as a code owner November 3, 2025 22:55
@cortisiko cortisiko added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Nov 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@cortisiko cortisiko added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 3bf2cf9 Nov 4, 2025
105 checks passed
@cortisiko cortisiko deleted the e2e/fix-assertions-for-claim-flow branch November 4, 2025 00:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants