test: allocate resource ports dynamically #22158
Merged
+2,427
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Introduced PortManager to handle port allocation and release for various servers. - Updated Ganache, MockServerE2E, DappServer, CommandQueueServer, FixtureServer, and AnvilManager to utilize PortManager for setting and releasing ports. - Added methods to set server ports and handle server status in respective classes. - Implemented retry logic for starting resources with automatic port management to avoid conflicts. - Updated FixtureUtils to include new port management functions and ensure correct RPC URLs are used based on allocated ports.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
cmd-ob
added
no-changelog
…al node management
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22158 +/- ##
==========================================
+ Coverage 77.02% 77.39% +0.36%
==========================================
Files 3805 3805
Lines 97085 96984 -101
Branches 18926 18911 -15
==========================================
+ Hits 74781 75057 +276
+ Misses 17164 16786 -378
- Partials 5140 5141 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…odes fixture urls
…ynamic-port-allocation
…ynamic-port-allocation
- Updated PortManager to use ResourceType instead of ResourceId for better clarity and maintainability. - Introduced new methods for handling multi-instance resources and automatic port forwarding for Android. - Refactored FixtureUtils to provide fallback ports for fixture data construction. - Updated various fixture-related classes to utilize new port management methods. - Removed deprecated functions and ensured backward compatibility where necessary. - Improved logging for resource allocation and port management.
…ility and remove translateFallbackPortToActual in mockserver
cmd-ob
force-pushed
the
e2e/dynamic-port-allocation
branch
from
88511b1 to
96dd1e5
Compare
…e its visibility for better testability
…tance is not available
…amask-mobile into e2e/dynamic-port-allocation
| for (let i = 1; i <= extraTabs; i++) { | ||
| this.fixture.state.browser.tabs.push({ | ||
| url: getTestDappLocalUrlByDappCounter(i), | ||
| url: getDappUrl(i), |
There was a problem hiding this comment.
Bug: Premature Port Access Breaks Fixture Construction
Calling getDappUrl(i) during fixture construction will fail on iOS because it calls getDappPort() which accesses PortManager before ports are allocated. This should use getDappUrlForFixture(i) instead, which returns fallback ports safe for fixture construction. On Android this works by coincidence since getDappUrl() returns fallback ports, but iOS will throw an error.
christopherferreira9
added
the
run-android-flask-e2e-smoke
christopherferreira9
approved these changes
Nov 12, 2025
Contributor
christopherferreira9
left a comment
christopherferreira9
left a comment
There was a problem hiding this comment.
LGTM great work!
|
shane-t
approved these changes
Nov 12, 2025
nickewansmith
approved these changes
Nov 12, 2025
georgewrmarshall
approved these changes
Nov 12, 2025
metamaskbot
added
the
release-7.60.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds PortManager-driven dynamic port allocation with retries and platform handling, refactors test servers/utilities to use it, migrates swaps tests to Anvil, and standardizes “Network fee” casing.
PortManagerfor dynamic/random port allocation (single/multi-instance), release, and BrowserStack fallbacks; adds robust retry start helpers (startResourceWithRetry,startMultiInstanceResourceWithRetry).adb reversemapping, iOS LaunchArgs, and MockServer host-side fallback→actual port translation.Ganache,AnvilManager,FixtureServer,CommandQueueServer,DappServer,MockServerE2EtosetServerPort, track status, and release ports;DappServersupports multi-instance.FixtureUtils/FixtureHelperAPIs (getDappUrl*,get*PortForFixture, RPC/Dapp URL rewrites) and improves network-store/shim host resolution.PortManager.test.ts.Network feeacross tests andlocales/languages/en.json.Written by Cursor Bugbot for commit f63e958. This will update automatically on new commits. Configure here.