-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(perps): change fee rounding for small fees #22264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+296
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/components/UI/Perps/Views/PerpsTransactionsView/PerpsPositionTransactionView.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/Perps/Views/PerpsTransactionsView/PerpsOrderTransactionView.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/Perps/Views/PerpsTransactionsView/PerpsPositionTransactionView.tsx
Outdated
Show resolved
Hide resolved
abretonc7s
approved these changes
Nov 10, 2025
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.60.0
Issue or pull request that will be included in release 7.60.0
size-M
team-perps
Perps team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Adds a small-fee threshold to show "< $0.01" for fees below $0.01, improving readability and avoiding misleading precision.
Changelog
CHANGELOG entry: Display < $0.01 for small fees in Perps
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1970
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces
formatFeeto show "< $0.01" for fees below $0.01 and updates Perps transaction views and tests to use it.formatFeeinapp/components/UI/Perps/utils/formatUtils.tsto return"$0","< $0.01", or formatted fiat; add comprehensive unit tests.formatFeeinPerpsOrderTransactionView.tsxandPerpsPositionTransactionView.tsx; ensure unfilled orders show$0."< $0.01"behavior and edge cases; keep existing explorer navigation tests intact.Written by Cursor Bugbot for commit cf07474. This will update automatically on new commits. Configure here.