fix: use METAMASK_ENVIRONMENT instead of NODE_ENV

[asalsys]

Description

Use metamask enviornment variable instead of node_env to view feature override dashboard

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user navigates to Feature Flag Override Dashboard in settings
    Given the metamask eviornment is not production

    When user navigates to settings
    Then they will see and navigate to the Feature Flag Override Dashboard

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Switches visibility gating from NODE_ENV to METAMASK_ENVIRONMENT for Feature Flag Override screens and adds tests; also memoizes feature flag context helpers.

• Navigation & Settings
  • Replace process.env.NODE_ENV !== 'production' with process.env.METAMASK_ENVIRONMENT !== 'production' to conditionally show Routes.FEATURE_FLAG_OVERRIDE in MainNavigator and the Feature Flag Override drawer in Views/Settings.
• Tests
  • Update MainNavigator.test.tsx and Views/Settings/index.test.tsx to use METAMASK_ENVIRONMENT, including setup/teardown of env var and assertions that Feature Flag Override is present in non-production.
• Feature Flag Context
  • Memoize featureFlagsList, getFeatureFlag, and the provided context value via useMemo/useCallback.
  • Use process.env.METAMASK_ENVIRONMENT in minimum version validation.

^{Written by Cursor Bugbot for commit 1ab6560. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Bug: Defaulting environment check reveals feature flag override dashboard

When METAMASK_ENVIRONMENT is undefined, the condition evaluates to true because undefined !== 'production', incorrectly showing the Feature Flag Override dashboard. This differs from the original NODE_ENV behavior which typically has a default value. The safer approach would be to explicitly check for non-production values or provide a default.

 

[cursor]

Bug: Non-Production Burn-In Flag Activation Bug

When METAMASK_ENVIRONMENT is undefined, the condition evaluates to true because undefined !== 'production', incorrectly registering the Feature Flag Override screen. This differs from the original NODE_ENV behavior which typically has a default value. The safer approach would be to explicitly check for non-production values or provide a default.

 

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.88%. Comparing base (dddee92) to head (ac01b7c).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #22282      +/-   ##
==========================================
+ Coverage   77.86%   77.88%   +0.02%     
==========================================
  Files        3826     3823       -3     
  Lines       98105    97831     -274     
  Branches    19236    19211      -25     
==========================================
- Hits        76389    76200     -189     
+ Misses      16480    16397      -83     
+ Partials     5236     5234       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud