chore: cp-7.59.0 revert font preloader changes from #21199

[georgewrmarshall]

Description

This PR reverts commit 74b8745 from PR #21199.

What is the reason for the change?
The font preloader changes introduced in #21199 are causing rendering bugs in the application:

• Text is being cut off in various components
• Font weights are not loading correctly
• The comprehensive font preloading approach is causing unexpected layout issues

What is the improvement/solution?
This revert restores the previous variant-based font preloading approach, which:

• Preloads only the specific TextVariant fonts that are actively used
• Maintains stable font rendering without text cutoff issues
• Ensures font weights load properly across all components
• Restores the working implementation until the font loading issues can be properly addressed

Changelog

CHANGELOG entry: null

Related issues

Fixes: #22301
Reverts: #21199
Original commit: 74b8745

Manual testing steps

Feature: Font rendering after revert

  Scenario: user views text content across the app
    Given the user has the app running with the reverted font preloader
    And the user navigates through different screens with various text components

    When the user views text content in input fields, headings, and body text
    Then all text should be fully visible without cutoff
    And font weights should render correctly (regular, medium, bold)
    And there should be no layout shifting or text overflow issues

Screenshots/Recordings

Before

N/A - This is a revert PR

After

N/A - This is a revert PR

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

🤖 Generated with Claude Code

---

Note

Reverts/rewrites font preloader to load only TextVariant fonts and updates input styles to set fontWeight from theme while removing hardcoded lineHeight/fontFamily; updates tests and snapshots accordingly.

• Fonts:
  • Preloader (app/core/FontPreloader/FontPreloader.ts): revert to variant-based font loading using TextVariant and getFontFamily; preload 400/500/700 weights on web; streamline native preload and logging.
  • Tests (app/core/FontPreloader/__tests__/FontPreloader.test.ts): simplify and align with new preloader behavior (singleton, RN preload, concurrency, reset, errors, promise access).
• UI Styles:
  • Inputs (app/component-library/.../Input.styles.ts): apply fontWeight from theme.typography[textVariant]; keep baseline alignment; minor comment/format tweak.
  • Remove hardcoded fontFamily in custom inputs (Views/EnterPasswordSimple/index.js, Views/RevealPrivateCredential/styles.ts, Views/MultichainAccounts/PrivateKeyList/styles.ts).
• Snapshots: update across UI to reflect fontWeight: "400" and removal of explicit lineHeight/fontFamily where applicable.

^{Written by Cursor Bugbot for commit 09ccad9. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

This seems like a mistake that we want to keep I'll create a follow up PR to fix the inputs specifically

[cursor]

Bug: Merged Comments Break Code

The comment and code are merged on the same line without proper line break. The comment // Ensure consistent line height for custom font baseline alignment is concatenated directly with the code lineHeight: Platform.OS === 'ios' ? 20 : 22, on line 48, which will cause a syntax error. The newline character between the comment and the code statement was accidentally removed during the revert.

 

[georgewrmarshall]

Quality Gate failed

Failed conditions 40.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

In the PR that we are reverting was the testing coverage for the font preloader. Ignoring Sonar Qube coverage check because of this

[sonarqubecloud]

Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud