chore: copy github gradle properties #22356
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/less-resources-for-gradle #22356 +/- ##
==================================================================
Coverage ? 77.85%
==================================================================
Files ? 3824
Lines ? 97952
Branches ? 19192
==================================================================
Hits ? 76257
Misses ? 16473
Partials ? 5222 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… actually created
| prebuild_android | ||
| cd android && ./gradlew assembleProdRelease app:assembleProdReleaseAndroidTest -PminSdkVersion=26 -DtestBuildType=release | ||
| # Use GitHub CI gradle properties for E2E builds (x86_64 only, optimized memory settings) | ||
| cp android/gradle.properties.github android/gradle.properties |
There was a problem hiding this comment.
Bug: Unbacked Overwrites Cause Local Data Loss
The cp command overwrites android/gradle.properties without backing it up first. When developers run E2E builds locally, their custom gradle properties are permanently lost since the original file is never restored. This differs from CI where the file system is ephemeral. Consider backing up the original file before overwriting or checking if running in CI before copying.
There was a problem hiding this comment.
Why would I need to back it up if I don't use it after?
| prebuild_android | ||
| cd android && ./gradlew assembleProdRelease app:assembleProdReleaseAndroidTest -PminSdkVersion=26 -DtestBuildType=release | ||
| # Use GitHub CI gradle properties for E2E builds (x86_64 only, optimized memory settings) | ||
| cp android/gradle.properties.github android/gradle.properties |
There was a problem hiding this comment.
Bug: Builds Leave Repository in Modified State
The cp android/gradle.properties.github android/gradle.properties command permanently overwrites the tracked android/gradle.properties file without backing it up or restoring it afterward. This leaves the repository in a modified state after E2E builds, potentially affecting subsequent builds and causing unwanted git changes. The original file has different architecture settings that would be lost.
|
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds GitHub CI Gradle properties and a dedicated Android E2E build path (x86_64, retry, verification), and sets default androidTest APK paths in Detox.
buildAndroidReleaseE2Ewith flavor support, copiesandroid/gradle.properties.github, retries with reduced parallelism on failure, and verifies APK outputs.buildAndroidto the new flow formain/flaskand legacyreleaseE2E.generateAndroidBinary(Release): always builds APK and AAB and generates checksum.android/gradle.properties.githubwith balanced JVM/worker settings, disabled VFS watch,reactNativeArchitectures=x86_64, and related AndroidX/Hermes/new arch flags.testBinaryPathforandroid.debug,android.release, andandroid.flask.*apps.Written by Cursor Bugbot for commit a90ee02. This will update automatically on new commits. Configure here.