-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: metamask pay with send picker #22363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
956a63d to
efaa859
Compare
44194d4 to
c264c90
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22363 +/- ##
========================================
Coverage 77.86% 77.86%
========================================
Files 3826 3821 -5
Lines 98105 97840 -265
Branches 19236 19237 +1
========================================
- Hits 76389 76187 -202
+ Misses 16480 16416 -64
- Partials 5236 5237 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Pull Request is not mergeable



Description
Use asset picker from send flow in MetaMask Pay.
Also display disabled entries in token list, including associated message.
Changelog
CHANGELOG entry: null
Related issues
Fixes: #6174
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces the Pay With modal’s token selector with the Send flow’s Asset picker, adds disabled-token handling/no-gas messaging, drops the network selector modal, and updates hooks/types/tests accordingly.
send/assetpicker; filters to EVMERC20tokens, shows zero-balance tokens if required/selected, and disables tokens lacking native gas withpay_with_modal.no_gasmessage.disabledstate (press disabled, opacity) and optionaldisabledMessagedisplay.hideNfts,includeNoBalance,onTokenSelect,tokenFilter; adaptive search placeholder; NFT section hidden whenhideNfts.Routes.CONFIRMATION_PAY_WITH_NETWORK_MODALscreen and references.useAccountTokensaccepts{ includeNoBalance }to optionally include zero-balance assets.disabled/disabledMessagetoAssetType.useTransactionPayAvailableTokenshook and its tests.send.search_tokens,pay_with_modal.no_gas.Written by Cursor Bugbot for commit c264c90. This will update automatically on new commits. Configure here.