Skip to content

Conversation

@hjetpoluru
Copy link
Contributor

@hjetpoluru hjetpoluru commented Nov 10, 2025

Description

Enable the predictions e2e test

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Enables Prediction Market E2E smoke test jobs for Android and iOS and includes them in the aggregated smoke test reports.

  • CI Workflows (E2E Smoke):
    • Android:
      • Add prediction-market-android-smoke job using SmokePredictions tag.
      • Include prediction-market-android-smoke in report-android-smoke-tests.needs.
    • iOS:
      • Add prediction-market-ios-smoke job using SmokePredictions tag.
      • Include prediction-market-ios-smoke in report-ios-smoke-tests.needs.

Written by Cursor Bugbot for commit 2f20dbe. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Nov 10, 2025
@hjetpoluru hjetpoluru added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 10, 2025
@hjetpoluru hjetpoluru marked this pull request as ready for review November 10, 2025 15:06
github-merge-queue bot pushed a commit that referenced this pull request Nov 10, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Re-enabling the prediction smoke test workflow and observed that the
Cash Out Predict test is failing. Additional time is required to
investigate and fix the issue, so the test will be temporarily skipped
for now.

Disabling PR:
[#22161](#22161)

Enabling PR:
[#22415](#22415)

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Skips the "cash out on open position: Spurs vs. Pelicans" e2e test in
`predict-cash-out.spec.ts`.
> 
> - **Tests (E2E Predictions)**:
> - Skip cash-out test by changing to `it.skip` in
`e2e/specs/predict/predict-cash-out.spec.ts` ("Spurs vs. Pelicans").
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
93aa4fb. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@hjetpoluru hjetpoluru added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 10, 2025
@hjetpoluru hjetpoluru enabled auto-merge November 10, 2025 20:38
@sonarqubecloud
Copy link

@hjetpoluru hjetpoluru added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit 8b5a63d Nov 10, 2025
153 of 164 checks passed
@hjetpoluru hjetpoluru deleted the enable-prediction-e2e branch November 10, 2025 21:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants