fix(predict): improve placeOrder error handling

[matallui]

Description

This PR improves error handling in the Predict feature's placeOrder method by refactoring the control flow to fail fast and ensuring analytics tracking is consistent across both success and error paths.

Reason for change: The previous implementation had nested success/failure logic that made the code harder to follow and potentially allowed analytics events to be tracked incorrectly in edge cases.

Improvement:

• Refactored to throw immediately on failure, simplifying the control flow
• Moved analytics failure tracking to the catch block where it belongs
• Added support for detecting "unable to access this provider" error messages as eligibility errors in the Polymarket provider

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Predict order placement error handling

  Scenario: user places an order that fails
    Given user is on the Predict screen with a valid market

    When user attempts to place an order that fails (e.g., region restriction)
    Then the appropriate error message is displayed
    And analytics failure event is tracked correctly

  Scenario: user places a successful order
    Given user is on the Predict screen with a valid market

    When user places a valid order
    Then the order completes successfully
    And analytics completion event is tracked with correct amounts
    And user balance is optimistically updated

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Refactors placeOrder to fail fast with unified success/failed analytics and optimistic balance updates; adds detection of "unable to access this provider" as an eligibility error in Polymarket.

• PredictController (PredictController.ts):
  • placeOrder: Fail-fast on unsuccessful provider response; centralizes COMPLETED tracking after result parsing and moves FAILED tracking to catch block; keeps optimistic balance updates and real share price/amount derivation.
• PolymarketProvider (PolymarketProvider.ts):
  • placeOrder: Treats errors containing "unable to access this provider" (in addition to region block) as NOT_ELIGIBLE.

^{Written by Cursor Bugbot for commit 4cafad4. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[caieu]

LGTM